You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2023/02/27 21:30:31 UTC

[GitHub] [pulsar] merlimat commented on a diff in pull request #19503: [improve][meta]Allow version to start positive and grow by more than one

merlimat commented on code in PR #19503:
URL: https://github.com/apache/pulsar/pull/19503#discussion_r1119332424


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/Stat.java:
##########
@@ -55,4 +62,9 @@ public class Stat {
      * Whether the key-value pair had been created within the current "session".
      */
     final boolean createdBySelf;
+
+    /**
+     * Whether this is the first version of the key-value pair since it has been last created.
+     */
+    final boolean firstVersion;

Review Comment:
   `created` has the problem of being misleading on the get operation though. 
   
   If I do a `get()` and receive a value with `created` what does that really mean? The value is created in the sense that it exists :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org