You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:48:49 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2286: [WIP] Add Memfault integration
apache-mynewt-bot removed a comment on pull request #2286:
URL: https://github.com/apache/mynewt-core/pull/2286#issuecomment-626624614
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### apps/memfault_demo/src/main.c
<details>
```diff
@@ -49,10 +49,10 @@
struct os_callout send_bytes_co;
void
-bluetooth_driver_send_bytes(struct os_event* ev)
+bluetooth_driver_send_bytes(struct os_event * ev)
{
memfault_metrics_heartbeat_add(MEMFAULT_METRICS_KEY(BtBytesSent), 50);
- // [ ... code to send bluetooth data ... ]
+ /* [ ... code to send bluetooth data ... ] */
os_callout_reset(&send_bytes_co, os_time_ms_to_ticks32(2000));
}
```
</details>
#### sys/memfault/src/memfault_demo_cli.c
<details>
```diff
@@ -6,60 +6,77 @@
#include "memfault_common.h"
-static int prv_clear_core_cmd(int argc, char **argv) {
- return memfault_demo_cli_cmd_clear_core(argc, argv);
+static int
+prv_clear_core_cmd(int argc, char **argv)
+{
+ return memfault_demo_cli_cmd_clear_core(argc, argv);
}
-static int prv_get_core_cmd(int argc, char **argv) {
- return memfault_demo_cli_cmd_get_core(argc, argv);
+static int
+prv_get_core_cmd(int argc, char **argv)
+{
+ return memfault_demo_cli_cmd_get_core(argc, argv);
}
-static int prv_crash_example(int argc, char **argv) {
- return memfault_demo_cli_cmd_crash(argc, argv);
+static int
+prv_crash_example(int argc, char **argv)
+{
+ return memfault_demo_cli_cmd_crash(argc, argv);
}
-static int prv_get_device_info(int argc, char **argv) {
- return memfault_demo_cli_cmd_get_device_info(argc, argv);
+static int
+prv_get_device_info(int argc, char **argv)
+{
+ return memfault_demo_cli_cmd_get_device_info(argc, argv);
}
-static int prv_print_chunk_cmd(int argc, char **argv) {
- return memfault_demo_cli_cmd_print_chunk(argc, argv);
+static int
+prv_print_chunk_cmd(int argc, char **argv)
+{
+ return memfault_demo_cli_cmd_print_chunk(argc, argv);
}
-static int prv_heartbeat_trigger(int argc, char **argv) {
- memfault_metrics_heartbeat_debug_trigger();
- return 0;
+static int
+prv_heartbeat_trigger(int argc, char **argv)
+{
+ memfault_metrics_heartbeat_debug_trigger();
+ return 0;
}
-static int prv_heartbeat_print(int argc, char **argv) {
- memfault_metrics_heartbeat_debug_print();
- return 0;
+static int
+prv_heartbeat_print(int argc, char **argv)
+{
+ memfault_metrics_heartbeat_debug_print();
+ return 0;
}
-static int prv_test_trace_event(int argc, char **argv) {
- MEMFAULT_TRACE_EVENT(test);
- return 0;
+static int
+prv_test_trace_event(int argc, char **argv)
+{
+ MEMFAULT_TRACE_EVENT(test);
+ return 0;
}
static const struct shell_cmd os_commands[] = {
- SHELL_CMD("crash", prv_crash_example, NULL),
- SHELL_CMD("clear_core", prv_clear_core_cmd, NULL),
- SHELL_CMD("get_core", prv_get_core_cmd, NULL),
- SHELL_CMD("get_device_info", prv_get_device_info, NULL),
- SHELL_CMD("print_chunk", prv_print_chunk_cmd, NULL),
- SHELL_CMD("heartbeat_trigger", prv_heartbeat_trigger, NULL),
- SHELL_CMD("heartbeat_print", prv_heartbeat_print, NULL),
- SHELL_CMD("test_trace_event", prv_test_trace_event, NULL),
- { 0 },
+ SHELL_CMD("crash", prv_crash_example, NULL),
+ SHELL_CMD("clear_core", prv_clear_core_cmd, NULL),
+ SHELL_CMD("get_core", prv_get_core_cmd, NULL),
+ SHELL_CMD("get_device_info", prv_get_device_info, NULL),
+ SHELL_CMD("print_chunk", prv_print_chunk_cmd, NULL),
+ SHELL_CMD("heartbeat_trigger", prv_heartbeat_trigger, NULL),
+ SHELL_CMD("heartbeat_print", prv_heartbeat_print, NULL),
+ SHELL_CMD("test_trace_event", prv_test_trace_event, NULL),
+ { 0 },
};
-void shell_mflt_register(void)
+void
+shell_mflt_register(void)
{
- int rc;
+ int rc;
- rc = shell_register("mflt", os_commands);
- SYSINIT_PANIC_ASSERT_MSG(
- rc == 0, "Failed to register OS shell commands");
+ rc = shell_register("mflt", os_commands);
+ SYSINIT_PANIC_ASSERT_MSG(
+ rc == 0, "Failed to register OS shell commands");
- shell_register_default_module("mflt");
+ shell_register_default_module("mflt");
}
```
</details>
#### sys/memfault/src/memfault_platform_core.c
<details>
```diff
@@ -30,9 +30,11 @@
void
memfault_platform_halt_if_debugging(void)
{
-// if (hal_debugger_connected()) {
-// __asm("bkpt");
-// }
+/*
+ if (hal_debugger_connected()) {
+ __asm("bkpt");
+ }
+ */
}
void
@@ -49,7 +51,7 @@
metrics_period_sec = period_sec;
metrics_callback = callback;
metrics_callout_cb(NULL);
- return true; // indicates setup was successful
+ return true; /* indicates setup was successful */
}
uint64_t
@@ -74,20 +76,22 @@
const sMemfaultEventStorageImpl *evt_storage =
memfault_events_storage_boot(s_event_storage, sizeof(s_event_storage));
- // Pass the storage to collect reset info
+ /* Pass the storage to collect reset info */
memfault_reboot_tracking_collect_reset_info(evt_storage);
- // Pass the storage to initialize the trace event module
+ /* Pass the storage to initialize the trace event module */
memfault_trace_event_boot(evt_storage);
- // NOTE: crash count represents the number of unexpected reboots since the
- // last heartbeat was reported. In the simplest case if reboots are
- // unexpected, this can just be set to 1 but see memfault/metrics/metrics.h
- // how this can be tracked with the reboot_tracking module.
+ /*
+ NOTE: crash count represents the number of unexpected reboots since the
+ last heartbeat was reported. In the simplest case if reboots are
+ unexpected, this can just be set to 1 but see memfault/metrics/metrics.h
+ how this can be tracked with the reboot_tracking module.
+ */
sMemfaultMetricBootInfo boot_info = {
.unexpected_reboot_count = memfault_reboot_tracking_get_crash_count()
};
rc = memfault_metrics_boot(evt_storage, &boot_info);
- // NOTE: a non-zero value indicates a configuration error took place
+ /* NOTE: a non-zero value indicates a configuration error took place */
SYSINIT_PANIC_ASSERT(rc == 0);
memfault_reboot_tracking_reset_crash_count();
```
</details>
#### sys/memfault/src/memfault_platform_debug_log.c
<details>
```diff
@@ -7,43 +7,47 @@
#define MEMFAULT_DEBUG_LOG_BUFFER_SIZE_BYTES (128)
#endif
-void memfault_platform_log(eMemfaultPlatformLogLevel level, const char *fmt, ...) {
- va_list args;
- va_start(args, fmt);
+void
+memfault_platform_log(eMemfaultPlatformLogLevel level, const char *fmt, ...)
+{
+ va_list args;
+ va_start(args, fmt);
- char log_buf[MEMFAULT_DEBUG_LOG_BUFFER_SIZE_BYTES];
- vsnprintf(log_buf, sizeof(log_buf), fmt, args);
+ char log_buf[MEMFAULT_DEBUG_LOG_BUFFER_SIZE_BYTES];
+ vsnprintf(log_buf, sizeof(log_buf), fmt, args);
- const char *lvl_str = "???";
- switch (level) {
- case kMemfaultPlatformLogLevel_Debug:
- lvl_str = "dbg";
- break;
+ const char *lvl_str = "???";
+ switch (level) {
+ case kMemfaultPlatformLogLevel_Debug:
+ lvl_str = "dbg";
+ break;
- case kMemfaultPlatformLogLevel_Info:
- lvl_str = "inf";
- break;
+ case kMemfaultPlatformLogLevel_Info:
+ lvl_str = "inf";
+ break;
- case kMemfaultPlatformLogLevel_Warning:
- lvl_str = "wrn";
- break;
+ case kMemfaultPlatformLogLevel_Warning:
+ lvl_str = "wrn";
+ break;
- case kMemfaultPlatformLogLevel_Error:
- lvl_str = "err";
- break;
+ case kMemfaultPlatformLogLevel_Error:
+ lvl_str = "err";
+ break;
- default:
- break;
- }
- console_printf("<%s> <mflt>: %s\n", lvl_str, log_buf);
+ default:
+ break;
+ }
+ console_printf("<%s> <mflt>: %s\n", lvl_str, log_buf);
- va_end(args);
+ va_end(args);
}
-void memfault_platform_log_raw(const char *fmt, ...) {
- va_list args;
- va_start(args, fmt);
- vprintf(fmt, args);
- va_end(args);
- console_printf("\n");
+void
+memfault_platform_log_raw(const char *fmt, ...)
+{
+ va_list args;
+ va_start(args, fmt);
+ vprintf(fmt, args);
+ va_end(args);
+ console_printf("\n");
}
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org