You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by tzulitai <gi...@git.apache.org> on 2017/03/01 06:46:19 UTC
[GitHub] bahir-flink pull request #11: [BAHIR-91] Upgrade Flink version to 1.2.0
GitHub user tzulitai opened a pull request:
https://github.com/apache/bahir-flink/pull/11
[BAHIR-91] Upgrade Flink version to 1.2.0
This required some Flink state API updates in the tests. We probably should keep an extra eye for these kind of Flink API changes; the source APIs may be stable, but API changes like these can also break code in bahir-flink.
Note about the additional `maven-bundle-plugin` in the Redis connector:
After the 1.2.0 upgrade, the project had a new dependency to Apacheds JDBM 2.0.0-M2, which packages using the "bundle" type. The plugin helps recognizes the type when building.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/bahir-flink BAHIR-91
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit 9b9be286543fb8c972d48e715a724da261f71d24
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-03-01T06:41:21Z
[BAHIR-91] Upgrade Flink version to 1.2.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/bahir-flink/pull/11
Ah yes, I forgot about that. I'll change that to `1.2.0`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/11
Looks good. Merging change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink pull request #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/bahir-flink/pull/11#discussion_r103620565
--- Diff: pom.xml ---
@@ -90,7 +90,7 @@
<log4j.version>1.2.17</log4j.version>
<!-- Spark version -->
--- End diff --
minor note: I changed this line to `Flink version` in #10, so not changing it in this PR to avoid conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink pull request #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/11
I think the travis tests will fail because they are overwriting the Flink version.
I have a constant there for the Flink version. My initial plan was to support multiple Flink versions at the same time.
Do you think there is an easy way to still support 1.1. and 1.2 with the Bahir connectors?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/bahir-flink/pull/11
@rmetzger I don't think there's an easy way to do this, unless we try to make the affected connectors backwards compatible.
Just rebased on {{master}} to resolve conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #11: [BAHIR-91] Upgrade Flink version to 1.2.0
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/11
The travis build failed, probably because of the version override from the travis.yml.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---