You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openwhisk.apache.org by gi...@git.apache.org on 2017/05/23 19:56:44 UTC
[GitHub] dubeejw commented on a change in pull request #2255: Final conversion of api-experimental to web action (not experimental)
dubeejw commented on a change in pull request #2255: Final conversion of api-experimental to web action (not experimental)
URL: https://github.com/apache/incubator-openwhisk/pull/2255#discussion_r118090666
##########
File path: tools/cli/go-whisk/whisk/client.go
##########
@@ -375,14 +375,11 @@ func parseApplicationError(resp *http.Response, data []byte, v interface{}) (*ht
appErrResult := &AppErrorResult{}
err = json.Unmarshal(data, appErrResult)
- // Handle application errors that occur with blocking invocations when result is true (#5)
+ // Handle application errors that occur with blocking invocations when --result option is true (#5)
if err == nil && appErrResult.Error != nil {
Debug(DbgInfo, "Error code is null, blocking with result invocation error has occured\n")
- errMsg := wski18n.T(
- "The following application error was received: {{.err}}",
- map[string]interface{}{
- "err": *appErrResult.Error,
- })
+ errMsg := fmt.Sprintf("%v", *appErrResult.Error)
Review comment:
Does this return the application error from a normal action??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services