You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/03/17 15:47:30 UTC

[GitHub] [commons-collections] nhojpatrick opened a new pull request #293: [COLLECTIONS-806] Continue JUnit v5

nhojpatrick opened a new pull request #293:
URL: https://github.com/apache/commons-collections/pull/293


   Break Inherifance need for BulkTest constants
   
   TransformedSplitMapTest break inheritance of BulkTest
   
   IteratorIterableTest break inheritance of BulkTest
   
   Break Inheritance need for AbstractObjectTest
   
   Trying to reduce requirement for methods via inheritance, so breaking out common static or helper methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] nhojpatrick commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1072618707


   @garydgregory done, tests locally report
   
   `[WARNING] Tests run: 16937, Failures: 0, Errors: 0, Skipped: 4`
   
   so will look into the JDK 17 failures reported later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] garydgregory commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1081043950


   @nhojpatrick maybe https://github.com/apache/commons-collections/commit/b705855353272a1a50aee36cef21fb6bfbcc6da2 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990


   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#293](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4c828c) into [master](https://codecov.io/gh/apache/commons-collections/commit/f55268b092dd63e0a02900623881ce7860261a19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f55268b) will **decrease** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #293      +/-   ##
   ============================================
   - Coverage     85.80%   85.76%   -0.05%     
   + Complexity     4674     4671       -3     
   ============================================
     Files           292      292              
     Lines         13472    13472              
     Branches       1955     1955              
   ============================================
   - Hits          11560    11554       -6     
   - Misses         1332     1338       +6     
     Partials        580      580              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ons4/splitmap/AbstractIterableGetMapDecorator.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL0Fic3RyYWN0SXRlcmFibGVHZXRNYXBEZWNvcmF0b3IuamF2YQ==) | `61.90% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ons/collections4/splitmap/TransformedSplitMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL1RyYW5zZm9ybWVkU3BsaXRNYXAuamF2YQ==) | `65.38% <0.00%> (-11.54%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f55268b...a4c828c](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] garydgregory commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1072385267


   Hi @nhojpatrick 
   Please rebase.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990


   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#293](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1596e50) into [master](https://codecov.io/gh/apache/commons-collections/commit/f55268b092dd63e0a02900623881ce7860261a19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f55268b) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #293      +/-   ##
   ============================================
   - Coverage     85.80%   85.71%   -0.10%     
   + Complexity     4674     4669       -5     
   ============================================
     Files           292      292              
     Lines         13472    13472              
     Branches       1955     1955              
   ============================================
   - Hits          11560    11547      -13     
   - Misses         1332     1342      +10     
   - Partials        580      583       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ons4/splitmap/AbstractIterableGetMapDecorator.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL0Fic3RyYWN0SXRlcmFibGVHZXRNYXBEZWNvcmF0b3IuamF2YQ==) | `61.90% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ons/collections4/splitmap/TransformedSplitMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL1RyYW5zZm9ybWVkU3BsaXRNYXAuamF2YQ==) | `65.38% <0.00%> (-11.54%)` | :arrow_down: |
   | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `85.66% <0.00%> (-2.58%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f55268b...1596e50](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990


   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#293](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f76e199) into [master](https://codecov.io/gh/apache/commons-collections/commit/f55268b092dd63e0a02900623881ce7860261a19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f55268b) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #293      +/-   ##
   ============================================
   - Coverage     85.80%   85.71%   -0.10%     
   + Complexity     4674     4669       -5     
   ============================================
     Files           292      292              
     Lines         13472    13472              
     Branches       1955     1955              
   ============================================
   - Hits          11560    11547      -13     
   - Misses         1332     1342      +10     
   - Partials        580      583       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ons4/splitmap/AbstractIterableGetMapDecorator.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL0Fic3RyYWN0SXRlcmFibGVHZXRNYXBEZWNvcmF0b3IuamF2YQ==) | `61.90% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ons/collections4/splitmap/TransformedSplitMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL1RyYW5zZm9ybWVkU3BsaXRNYXAuamF2YQ==) | `65.38% <0.00%> (-11.54%)` | :arrow_down: |
   | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `85.66% <0.00%> (-2.58%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f55268b...f76e199](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] garydgregory commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1080431246


   > @garydgregory EmptyPropertiesTest passes locally on JDK 17, and that class is not touched in this PR so not sure how to fix it.
   
   Ask yourself: Does the OS matter? Does the default EOL sequence matter? Does the default Charset matter? What else is different between my environment and the GutHub build environment? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990


   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#293](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (93b0fd1) into [master](https://codecov.io/gh/apache/commons-collections/commit/f55268b092dd63e0a02900623881ce7860261a19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f55268b) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #293   +/-   ##
   =========================================
     Coverage     85.80%   85.80%           
     Complexity     4674     4674           
   =========================================
     Files           292      292           
     Lines         13472    13472           
     Branches       1955     1955           
   =========================================
     Hits          11560    11560           
     Misses         1332     1332           
     Partials        580      580           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f55268b...93b0fd1](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] garydgregory commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1072385267


   Hi @nhojpatrick 
   Please rebase.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] nhojpatrick commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
nhojpatrick commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1073028081


   @garydgregory EmptyPropertiesTest passes locally on JDK 17, and that class is not touched in this PR so not sure how to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990


   # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#293](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f76e199) into [master](https://codecov.io/gh/apache/commons-collections/commit/f55268b092dd63e0a02900623881ce7860261a19?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f55268b) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #293      +/-   ##
   ============================================
   - Coverage     85.80%   85.71%   -0.10%     
   + Complexity     4674     4669       -5     
   ============================================
     Files           292      292              
     Lines         13472    13472              
     Branches       1955     1955              
   ============================================
   - Hits          11560    11547      -13     
   - Misses         1332     1342      +10     
   - Partials        580      583       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ons4/splitmap/AbstractIterableGetMapDecorator.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL0Fic3RyYWN0SXRlcmFibGVHZXRNYXBEZWNvcmF0b3IuamF2YQ==) | `61.90% <0.00%> (-14.29%)` | :arrow_down: |
   | [...ons/collections4/splitmap/TransformedSplitMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L3NwbGl0bWFwL1RyYW5zZm9ybWVkU3BsaXRNYXAuamF2YQ==) | `65.38% <0.00%> (-11.54%)` | :arrow_down: |
   | [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/293/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `85.66% <0.00%> (-2.58%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f55268b...f76e199](https://codecov.io/gh/apache/commons-collections/pull/293?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-collections] codecov-commenter edited a comment on pull request #293: [COLLECTIONS-806] Continue JUnit v5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #293:
URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1071006990






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org