[jira] [Commented] (MYFACES-4482) jsf.js and faces.js old codebase fails on my decorator integration test

["Werner Punz (Jira)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618728#comment-17618728 ] 

Werner Punz commented on MYFACES-4482:
--------------------------------------

Turned out to be a small bug in the test codebase.

The getViewState decoration, did not return a value.

The new codebase seems to be more forgiving regarding an empty viewstate than the old one.

Both are valid implementations, this is just a slight variation in how to handle the case of an undefined viewstate (which should not happen anyway)

 

> jsf.js and faces.js old codebase fails on my decorator integration test
> -----------------------------------------------------------------------
>
>                 Key: MYFACES-4482
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4482
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 4.0.0-RC1, 2.3-next-M7
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Minor
>
> I have a set of integration tests which are currently hosted in a pull request for 4.0
> While the tests pass for the new codebase entirely, for the old one they fail on
> test-12 decoration, which tests whether the decorated apis are called correctly.
> This could be an issue with the testcases, but more likely we have a small bug in the old implementation which bypasses the api for one of the testcases and calls the impl directly. 
> We had several bugs in this area in the past, when people started to decorate the apis. Hence I wrote this test to begin with.
> I will work on this issue on monday and get this fixed either in the test or in the old soon to be legacy codebase.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)