[jira] [Commented] (AIRFLOW-1744) task.retries can be False

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217433#comment-16217433 ] 

ASF subversion and git services commented on AIRFLOW-1744:
----------------------------------------------------------

Commit f271d437a6d168521d6d6b06e43ce9262ba3dccf in incubator-airflow's branch refs/heads/master from [~bolke]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=f271d43 ]

[AIRFLOW-1744] Make sure max_tries can be set

task.retries can be False. Which is not acceptable
for
and integer field.

Closes #2713 from bolkedebruin/AIRFLOW-1744


> task.retries can be False 
> --------------------------
>
>                 Key: AIRFLOW-1744
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1744
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: Bolke de Bruin
>            Priority: Blocker
>             Fix For: 1.9.0
>
>
> When adding the max_tries field task.retries can be False (e.g. in case of a faulty day). At least Postgres will not accept "False" for an integer field. 
> It is proposed to set it to try_number in case try_number > 0 otherwise to 1.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)