[GitHub] [struts] nikosdimitrakas commented on pull request #692: [WW-5310] Supports fragment in URL

["nikosdimitrakas (via GitHub)" <gi...@apache.org>]

nikosdimitrakas commented on PR #692:
URL: https://github.com/apache/struts/pull/692#issuecomment-1572515644

   You could fix this without changing the signature of the method by defining that the incoming string must be the query string and nothing more. The fact that the few callers of the parse method provide everything after the ? in the url is the problem in my opinion. The class QueryStringParser should only be working with the query string. This way you can maintain backwards compatibility and make sure that the query string is handled correctly in the QuerystringParser and that the fragment identifier is handled correctly in the other classes (ServletUrlRenderer, ServlerDispatcherResult and DefaultUrlHelper). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org