You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/09 05:53:30 UTC
[GitHub] [incubator-linkis] CCweixiao opened a new pull request, #2254: [Feature] [1.2.0] Linkis jdbc engine supports multiple data source links.
CCweixiao opened a new pull request, #2254:
URL: https://github.com/apache/incubator-linkis/pull/2254
https://github.com/apache/incubator-linkis/issues/2092
Linkis jdbc engine supports multiple data source links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] CCweixiao commented on a diff in pull request #2254: [Feature] [1.2.0] Linkis jdbc engine supports multiple data source links.
Posted by GitBox <gi...@apache.org>.
CCweixiao commented on code in PR #2254:
URL: https://github.com/apache/incubator-linkis/pull/2254#discussion_r893114608
##########
linkis-engineconn-plugins/engineconn-plugins/jdbc/pom.xml:
##########
@@ -47,6 +47,54 @@
<version>${linkis.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.linkis</groupId>
+ <artifactId>linkis-datasource-client</artifactId>
+ <version>${linkis.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ </exclusion>
+ <exclusion>
Review Comment:
好的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2254: [Feature] [1.2.0] Linkis jdbc engine supports multiple data source links.
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2254:
URL: https://github.com/apache/incubator-linkis/pull/2254#discussion_r893111985
##########
linkis-engineconn-plugins/engineconn-plugins/jdbc/pom.xml:
##########
@@ -47,6 +47,54 @@
<version>${linkis.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.linkis</groupId>
+ <artifactId>linkis-datasource-client</artifactId>
+ <version>${linkis.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpcore</artifactId>
+ </exclusion>
+ <exclusion>
Review Comment:
maybe use
```
<exclusion>
<groupId>org.eclipse.jetty</groupId>
<artifactId>*</artifactId>
</exclusion>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] CCweixiao closed pull request #2254: [Feature] [1.2.0] Linkis jdbc engine supports multiple data source links.
Posted by GitBox <gi...@apache.org>.
CCweixiao closed pull request #2254: [Feature] [1.2.0] Linkis jdbc engine supports multiple data source links.
URL: https://github.com/apache/incubator-linkis/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org