You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/19 22:32:45 UTC

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7494: API to drop data by interval

surekhasaharan commented on a change in pull request #7494: API to drop data by interval
URL: https://github.com/apache/incubator-druid/pull/7494#discussion_r277099119
 
 

 ##########
 File path: docs/content/operations/api-reference.md
 ##########
 @@ -230,6 +230,20 @@ Enables all segments of datasource which are not overshadowed by others.
 
 Enables a segment of a datasource.
 
+##### PUT
 
 Review comment:
   ok, will update that in the proposal as well. I think drop API may be idempotent as calling it multiple times would do the same thing i.e. set `used=false` for the specified interval, but it's counterpart `reload` may not be. So i think it makes sense to change both to `POST`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org