[jira] [Commented] (HADOOP-15830) Server.java Prefer ArrayList

["Íñigo Goiri (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642271#comment-16642271 ] 

Íñigo Goiri commented on HADOOP-15830:
--------------------------------------

When going over the responses, we used to break (I guess assuming that they were in order).
That functionality is going, any thoughts there?
Everyhting else is pretty much the same.

> Server.java Prefer ArrayList
> ----------------------------
>
>                 Key: HADOOP-15830
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15830
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-13969.1.patch
>
>
> *  Prefer ArrayDeque over LinkedList (faster, less memory overhead)
> * Address this code:
> {code}
>     //
>     // Remove calls that have been pending in the responseQueue 
>     // for a long time.
>     //
>     private void doPurge(RpcCall call, long now) {
>       LinkedList<RpcCall> responseQueue = call.connection.responseQueue;
>       synchronized (responseQueue) {
>         Iterator<RpcCall> iter = responseQueue.listIterator(0);
>         while (iter.hasNext()) {
>           call = iter.next();
>           if (now > call.timestamp + PURGE_INTERVAL) {
>             closeConnection(call.connection);
>             break;
>           }
>         }
>       }
>     }
> {code}
> It says "Remove calls" (plural) but only one call will be removed because of the 'break' statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org