You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/05 03:57:30 UTC

[GitHub] [kafka] vamossagar12 commented on pull request #11424: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

vamossagar12 commented on pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#issuecomment-1005361882


   @guozhangwang , it's due to the usage of deprecated configs and gradle having a check against it.
   
   ```
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:61: warning: [deprecation] CACHE_MAX_BYTES_BUFFERING_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             .define(CACHE_MAX_BYTES_BUFFERING_CONFIG,
   
   [2022-01-04T23:35:30.575Z]                     ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:56: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]              .define(BUFFERED_RECORDS_PER_PARTITION_CONFIG,
   
   [2022-01-04T23:35:30.575Z]                      ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:115: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]         if (isTopologyOverride(BUFFERED_RECORDS_PER_PARTITION_CONFIG, topologyOverrides)) {
   
   [2022-01-04T23:35:30.575Z]                                ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:116: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             maxBufferedSize = getInt(BUFFERED_RECORDS_PER_PARTITION_CONFIG);
   
   [2022-01-04T23:35:30.575Z]                                      ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:117: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             log.info("Topology {} is overriding {} to {}", topologyName, BUFFERED_RECORDS_PER_PARTITION_CONFIG, maxBufferedSize);
   
   [2022-01-04T23:35:30.575Z]                                                                          ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:119: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             maxBufferedSize = globalAppConfigs.originals().containsKey(StreamsConfig.BUFFERED_RECORDS_PER_PARTITION_CONFIG)
   
   [2022-01-04T23:35:30.575Z]                                                                                     ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:120: warning: [deprecation] BUFFERED_RECORDS_PER_PARTITION_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]                     ? globalAppConfigs.getInt(StreamsConfig.BUFFERED_RECORDS_PER_PARTITION_CONFIG) : -1;
   
   [2022-01-04T23:35:30.575Z]                                                            ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:123: warning: [deprecation] CACHE_MAX_BYTES_BUFFERING_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]         if (isTopologyOverride(CACHE_MAX_BYTES_BUFFERING_CONFIG, topologyOverrides)) {
   
   [2022-01-04T23:35:30.575Z]                                ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:124: warning: [deprecation] CACHE_MAX_BYTES_BUFFERING_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             cacheSize = getLong(CACHE_MAX_BYTES_BUFFERING_CONFIG);
   
   [2022-01-04T23:35:30.575Z]                                 ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:125: warning: [deprecation] CACHE_MAX_BYTES_BUFFERING_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             log.info("Topology {} is overriding {} to {}", topologyName, CACHE_MAX_BYTES_BUFFERING_CONFIG, cacheSize);
   
   [2022-01-04T23:35:30.575Z]                                                                          ^
   
   [2022-01-04T23:35:30.575Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-11424/streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/TopologyConfig.java:127: warning: [deprecation] CACHE_MAX_BYTES_BUFFERING_CONFIG in org.apache.kafka.streams.StreamsConfig has been deprecated
   
   [2022-01-04T23:35:30.575Z]             cacheSize = globalAppConfigs.getLong(CACHE_MAX_BYTES_BUFFERING_CONFIG);
   
   [2022-01-04T23:35:30.575Z]                                                  ^
   
   [2022-01-04T23:35:30.575Z] error: warnings found and -Werror specified
   ```
   
   In my local I commented out that check for compile/test/checkstyle etc. I think we don't want to get rid of these configs immediately, so these usages are needed for now. What would you suggest here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org