You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AlexisBRENON (via GitHub)" <gi...@apache.org> on 2023/07/11 09:05:14 UTC
[GitHub] [airflow] AlexisBRENON opened a new pull request, #32515: Improve sensors timeout argument documentation
AlexisBRENON opened a new pull request, #32515:
URL: https://github.com/apache/airflow/pull/32515
Related: #32512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32515: Add timedelta support for applicable arguments of sensors
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32515:
URL: https://github.com/apache/airflow/pull/32515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] phanikumv commented on a diff in pull request #32515: Improve sensors timeout argument documentation
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #32515:
URL: https://github.com/apache/airflow/pull/32515#discussion_r1259593743
##########
airflow/sensors/base.py:
##########
@@ -87,9 +87,18 @@ class BaseSensorOperator(BaseOperator, SkipMixin):
a criteria is met and fail if and when they time out.
:param soft_fail: Set to true to mark the task as SKIPPED on failure
- :param poke_interval: Time in seconds that the job should wait in
- between each try
- :param timeout: Time, in seconds before the task times out and fails.
+ :param poke_interval: Time that the job should wait in between each try.
+ Can be ``timedelta`` or ``float`` seconds.
+ :param timeout: Time before the task times out and fails.
+ Can be ``timedelta`` or ``float`` seconds.
+ This should not be confused with ``execution_timeout`` of the
+ ``BaseOperator`` class. ``timeout`` measure the time between the
+ first poke and the current time (taking into account any
+ reschedule delay between each poke), while ``execution_timeout``
+ check the **running** time of the task (leaving out any reschedule
Review Comment:
```suggestion
checks the **running** time of the task (leaving out any reschedule
```
##########
airflow/sensors/base.py:
##########
@@ -87,9 +87,18 @@ class BaseSensorOperator(BaseOperator, SkipMixin):
a criteria is met and fail if and when they time out.
:param soft_fail: Set to true to mark the task as SKIPPED on failure
- :param poke_interval: Time in seconds that the job should wait in
- between each try
- :param timeout: Time, in seconds before the task times out and fails.
+ :param poke_interval: Time that the job should wait in between each try.
+ Can be ``timedelta`` or ``float`` seconds.
+ :param timeout: Time before the task times out and fails.
+ Can be ``timedelta`` or ``float`` seconds.
+ This should not be confused with ``execution_timeout`` of the
+ ``BaseOperator`` class. ``timeout`` measure the time between the
Review Comment:
```suggestion
``BaseOperator`` class. ``timeout`` measures the time elapsed between the
```
##########
airflow/sensors/base.py:
##########
@@ -87,9 +87,18 @@ class BaseSensorOperator(BaseOperator, SkipMixin):
a criteria is met and fail if and when they time out.
:param soft_fail: Set to true to mark the task as SKIPPED on failure
- :param poke_interval: Time in seconds that the job should wait in
- between each try
- :param timeout: Time, in seconds before the task times out and fails.
+ :param poke_interval: Time that the job should wait in between each try.
+ Can be ``timedelta`` or ``float`` seconds.
+ :param timeout: Time before the task times out and fails.
Review Comment:
```suggestion
:param timeout: Time elapsed before the task times out and fails.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AlexisBRENON commented on pull request #32515: Improve sensors timeout argument documentation
Posted by "AlexisBRENON (via GitHub)" <gi...@apache.org>.
AlexisBRENON commented on PR #32515:
URL: https://github.com/apache/airflow/pull/32515#issuecomment-1630676851
> Nice! Thanks @AlexisBRENON for taking the time to improve docs. I like the changes, I think though the title/description of the commit should be changed beceause it's more than doc change - it's also coertion and supporting timedelta.
Yeah, maybe it should be two different PRs ?
Or should I just update the title ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32515: Improve sensors timeout argument documentation
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32515:
URL: https://github.com/apache/airflow/pull/32515#issuecomment-1630666628
Nice! Thanks @AlexisBRENON for taking the time to improve docs. I likel the changes, I think though the title/description of the commit should be changed beceause it's more than doc change - it's also coertion and supporting timedelta.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #32515: Add timedelta support for applicable arguments of sensors
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #32515:
URL: https://github.com/apache/airflow/pull/32515#issuecomment-1630883739
> Or should I just update the title ?
Updating is fine :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org