You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Ted Husted <hu...@apache.org> on 2003/11/28 03:37:21 UTC
Re: Maven test run
When I run the maven jar target, the upload tests fail
(MultipartTestSuite).
But, when I run the ant test.junit test, only the
TestActionConfigMatcher test fails.
Is it me, or do others share this experience?
If so, any ideas as to why this would be?
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by "Craig R. McClanahan" <cr...@apache.org>.
Quoting Joe Germuska <jo...@germuska.com>:
> On Nov 28, 2003, at 3:08 AM, Steve Raeburn wrote:
>
> > I've updated project.xml to reference the validator 1.1.1 jar. You need
> > to manually download it from http://www.apache.org/~rleland/ and place
> > it in your local repository.
>
> Would it be a good idea to make an alternate JAR repository for Struts
> so that this step can be automated without depending on the iBiblio
> managers? It's trivial to do in Maven -- in fact, now that I look, I
> see that it's configured in the "project.properties" file, but that
> line is commented out:
>
> #maven.repo.remote=http://www.ibiblio.org/maven/,http://
> jakarta.apache.org/struts/repo
>
> Any reason not to set that up so that it works?
>
FWIW, an Incubator project to set up a formal Apache repository (Ruper) is just
in the startup stages. Among other things, this will include covering the
policy issues around publishing JARs into such a repository (which, after all,
is effectively a release vehicle and therefore needs the same sort of
management as the release directories do), and the possibility to leverage the
mirrorring architecture. The initial focus is *not* going to be on tools that
manage the repository, but I'm sure you'll see any necessary changes added to
things like Ant and Maven in short order.
Anyone interested in participating in this effort is encouraged to join the
Incubator related mailling lists (start at http://incubator.apache.org and the
general@incubator.apaache.org mailing list). In the mean time, though, I would
suggest that we *not* try to create a Struts-specific repository that would
quickly become redundant.
If a short term action is needed to avoid dependence on ibiblio, we could pretty
easily document how to set up and populate your own local repository.
> My big project is out the door, so I'll try to sneak in some time
> catching up with Struts and Maven stuff before things get away from me
> again...
>
Your help on the Maven configuration and build scripts is much appreciated!
> Joe
>
Craig
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Ted Husted <hu...@apache.org>.
Ted Husted wrote:
> Ditto for any of our Commons JAR dependencies.
... that we are using for a release trigger, like Commons-Validator for
1.2.0
-T.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Martin Cooper <ma...@apache.org>.
On Wed, 3 Dec 2003, Steve Raeburn wrote:
> http://maven.apache.org/repository-upload.html
>
> Perhaps, if Maven is widely adopted by Apache projects, it would make
> sense to set up an Apache based repository. Then projects would be able
> to directly publish their own jars.
This idea has been bandied about on infrastructure@ several times. Right
now, they're in the process of procuring some serious new hardware for
Apache. Once that's in place, I wouldn't be surprised to see an Apche repo
for Maven (amongst other) builds. That would make a lot of folks happy.
:-)
--
Martin Cooper
>
> Steve
>
> > -----Original Message-----
> > From: Ted Husted [mailto:husted@apache.org]
> > Sent: December 3, 2003 6:33 AM
> > To: Struts Developers List
> > Subject: Re: Maven test run
> >
> >
> > Joe Germuska wrote:
> > > Would it be a good idea to make an alternate JAR
> > repository for Struts
> > > so that this step can be automated without depending on the iBiblio
> > > managers? It's trivial to do in Maven -- in fact, now
> > that I look, I
> > > see that it's configured in the "project.properties" file, but that
> > > line is commented out:
> > >
> > > #maven.repo.remote=http://www.ibiblio.org/maven/,http://
> > > jakarta.apache.org/struts/repo
> > >
> > > Any reason not to set that up so that it works?
> >
> > I'm still not clear on how the whole ibiblio thing works.
> > But, yes, we
> > should be making our nightly snapshot JAR available someplace and
> > updating it every day as part of an automated process. Ditto
> > for any of
> > our Commons JAR dependencies.
> >
> > One question would be whether we should be distributing JARs
> > from this
> > server or not. Infrastructure is trying to limit the points of access
> > for distributions.
> >
> > -Ted.
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Martin Cooper <ma...@apache.org>.
On Wed, 3 Dec 2003, Tim Chen wrote:
> Using Maven on a few of my projects I've often felt the same way.
> It would be nice to not have to wait for someone to submit a request for
> a new jar to be put on ibiblio (that's how its done currently) before
> being able to use it in your own project. We've either set up a
> repository for or dropped in manually latest/greatest jars that we need
> just so that we dont have to wait for ibibilio.
> A jakarta wide maven like repository would be awesome to this respect.
> Since jakarta has a pretty easy to access repository already
> (http://apache.takiweb.com/jakarta/) it shouldnt be too difficult to add
> a few folders to make it maven friendly.
There are plenty of Jakarta (and Apache) mirrors around. However, there's
always the question of trust. People are always supposed to verify their
downloads from a mirror against the signatures on the main Apache site.
For an automated build process to be trustworthy, it would either have to
do that same verification automatically (unlikely, IMHO) or obtain its
dependencies from an Apache server. That means an Apache repo, as Steve
suggested.
--
Martin Cooper
> -Tim
>
> Steve Raeburn wrote:
>
> >http://maven.apache.org/repository-upload.html
> >
> >Perhaps, if Maven is widely adopted by Apache projects, it would make
> >sense to set up an Apache based repository. Then projects would be able
> >to directly publish their own jars.
> >
> >Steve
> >
> >
> >
> >>-----Original Message-----
> >>From: Ted Husted [mailto:husted@apache.org]
> >>Sent: December 3, 2003 6:33 AM
> >>To: Struts Developers List
> >>Subject: Re: Maven test run
> >>
> >>
> >>Joe Germuska wrote:
> >> > Would it be a good idea to make an alternate JAR
> >>repository for Struts
> >> > so that this step can be automated without depending on the iBiblio
> >> > managers? It's trivial to do in Maven -- in fact, now
> >>that I look, I
> >> > see that it's configured in the "project.properties" file, but that
> >> > line is commented out:
> >> >
> >> > #maven.repo.remote=http://www.ibiblio.org/maven/,http://
> >> > jakarta.apache.org/struts/repo
> >> >
> >> > Any reason not to set that up so that it works?
> >>
> >>I'm still not clear on how the whole ibiblio thing works.
> >>But, yes, we
> >>should be making our nightly snapshot JAR available someplace and
> >>updating it every day as part of an automated process. Ditto
> >>for any of
> >>our Commons JAR dependencies.
> >>
> >>One question would be whether we should be distributing JARs
> >>from this
> >>server or not. Infrastructure is trying to limit the points of access
> >>for distributions.
> >>
> >>-Ted.
> >>
> >>
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Tim Chen <tc...@tampabay.rr.com>.
Using Maven on a few of my projects I've often felt the same way.
It would be nice to not have to wait for someone to submit a request for
a new jar to be put on ibiblio (that's how its done currently) before
being able to use it in your own project. We've either set up a
repository for or dropped in manually latest/greatest jars that we need
just so that we dont have to wait for ibibilio.
A jakarta wide maven like repository would be awesome to this respect.
Since jakarta has a pretty easy to access repository already
(http://apache.takiweb.com/jakarta/) it shouldnt be too difficult to add
a few folders to make it maven friendly.
-Tim
Steve Raeburn wrote:
>http://maven.apache.org/repository-upload.html
>
>Perhaps, if Maven is widely adopted by Apache projects, it would make
>sense to set up an Apache based repository. Then projects would be able
>to directly publish their own jars.
>
>Steve
>
>
>
>>-----Original Message-----
>>From: Ted Husted [mailto:husted@apache.org]
>>Sent: December 3, 2003 6:33 AM
>>To: Struts Developers List
>>Subject: Re: Maven test run
>>
>>
>>Joe Germuska wrote:
>> > Would it be a good idea to make an alternate JAR
>>repository for Struts
>> > so that this step can be automated without depending on the iBiblio
>> > managers? It's trivial to do in Maven -- in fact, now
>>that I look, I
>> > see that it's configured in the "project.properties" file, but that
>> > line is commented out:
>> >
>> > #maven.repo.remote=http://www.ibiblio.org/maven/,http://
>> > jakarta.apache.org/struts/repo
>> >
>> > Any reason not to set that up so that it works?
>>
>>I'm still not clear on how the whole ibiblio thing works.
>>But, yes, we
>>should be making our nightly snapshot JAR available someplace and
>>updating it every day as part of an automated process. Ditto
>>for any of
>>our Commons JAR dependencies.
>>
>>One question would be whether we should be distributing JARs
>>from this
>>server or not. Infrastructure is trying to limit the points of access
>>for distributions.
>>
>>-Ted.
>>
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>>
>>
>>
>>
>>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Steve Raeburn <sr...@apache.org>.
http://maven.apache.org/repository-upload.html
Perhaps, if Maven is widely adopted by Apache projects, it would make
sense to set up an Apache based repository. Then projects would be able
to directly publish their own jars.
Steve
> -----Original Message-----
> From: Ted Husted [mailto:husted@apache.org]
> Sent: December 3, 2003 6:33 AM
> To: Struts Developers List
> Subject: Re: Maven test run
>
>
> Joe Germuska wrote:
> > Would it be a good idea to make an alternate JAR
> repository for Struts
> > so that this step can be automated without depending on the iBiblio
> > managers? It's trivial to do in Maven -- in fact, now
> that I look, I
> > see that it's configured in the "project.properties" file, but that
> > line is commented out:
> >
> > #maven.repo.remote=http://www.ibiblio.org/maven/,http://
> > jakarta.apache.org/struts/repo
> >
> > Any reason not to set that up so that it works?
>
> I'm still not clear on how the whole ibiblio thing works.
> But, yes, we
> should be making our nightly snapshot JAR available someplace and
> updating it every day as part of an automated process. Ditto
> for any of
> our Commons JAR dependencies.
>
> One question would be whether we should be distributing JARs
> from this
> server or not. Infrastructure is trying to limit the points of access
> for distributions.
>
> -Ted.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Ted Husted <hu...@apache.org>.
Joe Germuska wrote:
> Would it be a good idea to make an alternate JAR repository for Struts
> so that this step can be automated without depending on the iBiblio
> managers? It's trivial to do in Maven -- in fact, now that I look, I
> see that it's configured in the "project.properties" file, but that
> line is commented out:
>
> #maven.repo.remote=http://www.ibiblio.org/maven/,http://
> jakarta.apache.org/struts/repo
>
> Any reason not to set that up so that it works?
I'm still not clear on how the whole ibiblio thing works. But, yes, we
should be making our nightly snapshot JAR available someplace and
updating it every day as part of an automated process. Ditto for any of
our Commons JAR dependencies.
One question would be whether we should be distributing JARs from this
server or not. Infrastructure is trying to limit the points of access
for distributions.
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Joe Germuska <jo...@germuska.com>.
On Nov 28, 2003, at 3:08 AM, Steve Raeburn wrote:
> I've updated project.xml to reference the validator 1.1.1 jar. You need
> to manually download it from http://www.apache.org/~rleland/ and place
> it in your local repository.
Would it be a good idea to make an alternate JAR repository for Struts
so that this step can be automated without depending on the iBiblio
managers? It's trivial to do in Maven -- in fact, now that I look, I
see that it's configured in the "project.properties" file, but that
line is commented out:
#maven.repo.remote=http://www.ibiblio.org/maven/,http://
jakarta.apache.org/struts/repo
Any reason not to set that up so that it works?
My big project is out the door, so I'll try to sneak in some time
catching up with Struts and Maven stuff before things get away from me
again...
Joe
--
Joe Germuska
Joe@Germuska.com
http://blog.germuska.com
"We want beef in dessert if we can get it there."
-- Betty Hogan, Director of New Product Development, National
Cattlemen's Beef Association
Re: Maven test run
Posted by Ted Husted <hu...@apache.org>.
OK, the Maven build is looking good. Thanks ever so much, Tim!
Now the next question on this front is what to do about the various web
applications?
We had been rolling these into the binary distribution as WARS. The
default Maven dist target seems fine for core, but it may be hard to
extend to do exactly what we did before.
I believe the cannonical Maven answer would be to have another
distribution for the web applications, or perhaps a distribution for each.
Thoughts? Experiences? Wild ideas?
At this point, I'm neither suggesting nor assuming that we would want to
distribute 1.2.0 via Maven. Though, it's now becoming a possibility. I'm
taking a close look at the site build now.
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Ted Husted <hu...@apache.org>.
We are interested in fixing the Maven build. The tests seem to run under
the conventional build, which would imply that the issue may be in the
Maven setup.
Along with the core, we would also need a strategy for building the
various example web applications. I'm thinking we may need a master
webapps-projects.xml that each application artifact could extend.
-Ted.
Tim Chen wrote:
> I submitted a patch recently for the maven build.
> Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a
> formal bugzilla report as Rob had suggested that I do.
> The maven test currently fail because the resources are not provided
> (look at my past post for reference). Unfortunately, even after
> including the source there are still test failures. I posted a sniplet
> of one of the errors before.
> I never bothered to find out if those test failures were due to the
> maven build or because of incorrectly written tests.
> Either way, I'll try to find some time to fix the maven build if anyone
> is interested.
>
> Tim Chen
> tchen@tampabay.rr.com
>
>
> -----Original Message-----
> From: Ted Husted [mailto:husted@apache.org]
> Sent: Friday, November 28, 2003 8:50 AM
> To: Struts Developers List
> Subject: Re: Maven test run
>
>
> Steve Raeburn wrote:
>
>>There were no tests found because the test section was commented out!
>>(and the example include pattern doesn't match our naming convention).
>
>
>>I've enabled the JUnit tests. Using Cactus with Maven is beyond me,
>>for now :-)
>
>
> Mea culpa on the comment block. I did that to see if I could get the
> rest of it to run, and then committed it accidentally. <head-slap/>
>
>
>>When Maven runs the tests, TestModuleConfig is throwing a
>>NullPointerException that doesn't show up when running from Ant. I'm
>>inclined to believe that the Maven configuration requires more work
>>rather that it actually being a problem with ModuleConfig.
>
> >
>
>>The Maven build remains HIGHLY experimental!!
>
>
> I wonder if we could try a compromise? Could we have a Maven build that
> just downloaded the dependencies into the central repository, and a
> build.properties that got everything from there. This would save us from
>
> going back to a "struts-library" distribution.
>
> I also wonder if it be possible to wrap our existing Ant build as Maven
> goals? The user guide says that any Ant task can be used in the
> maven.xml.
>
> http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
>
> Another stepping-stone might be to provide Maven projects for the
> examples applications, especially the blank application. I'm thinking
> the cannonical approach here would be to have a master
> webapp-project.xml that we then extended for each application
> "artifact".
>
> http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
>
> I'm working on a changelog system now but will come back to this later,
> if no one beats me to it. [Please do, if you can :)]
>
> -Ted.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
--
Ted Husted,
Junit in Action - <http://www.manning.com/massol/>,
Struts in Action - <http://husted.com/struts/book.html>,
JSP Site Design - <http://www.amazon.com/exec/obidos/ISBN=1861005512>.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Tim Chen <tc...@tampabay.rr.com>.
I submitted a patch recently for the maven build.
Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a
formal bugzilla report as Rob had suggested that I do.
The maven test currently fail because the resources are not provided
(look at my past post for reference). Unfortunately, even after
including the source there are still test failures. I posted a sniplet
of one of the errors before.
I never bothered to find out if those test failures were due to the
maven build or because of incorrectly written tests.
Either way, I'll try to find some time to fix the maven build if anyone
is interested.
Tim Chen
tchen@tampabay.rr.com
-----Original Message-----
From: Ted Husted [mailto:husted@apache.org]
Sent: Friday, November 28, 2003 8:50 AM
To: Struts Developers List
Subject: Re: Maven test run
Steve Raeburn wrote:
> There were no tests found because the test section was commented out!
> (and the example include pattern doesn't match our naming convention).
> I've enabled the JUnit tests. Using Cactus with Maven is beyond me,
> for now :-)
Mea culpa on the comment block. I did that to see if I could get the
rest of it to run, and then committed it accidentally. <head-slap/>
> When Maven runs the tests, TestModuleConfig is throwing a
> NullPointerException that doesn't show up when running from Ant. I'm
> inclined to believe that the Maven configuration requires more work
> rather that it actually being a problem with ModuleConfig.
>
> The Maven build remains HIGHLY experimental!!
I wonder if we could try a compromise? Could we have a Maven build that
just downloaded the dependencies into the central repository, and a
build.properties that got everything from there. This would save us from
going back to a "struts-library" distribution.
I also wonder if it be possible to wrap our existing Ant build as Maven
goals? The user guide says that any Ant task can be used in the
maven.xml.
http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
Another stepping-stone might be to provide Maven projects for the
examples applications, especially the blank application. I'm thinking
the cannonical approach here would be to have a master
webapp-project.xml that we then extended for each application
"artifact".
http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
I'm working on a changelog system now but will come back to this later,
if no one beats me to it. [Please do, if you can :)]
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Ted Husted <hu...@apache.org>.
Steve Raeburn wrote:
> There were no tests found because the test section was commented out!
> (and the example include pattern doesn't match our naming convention).
> I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for
> now :-)
Mea culpa on the comment block. I did that to see if I could get the
rest of it to run, and then committed it accidentally. <head-slap/>
> When Maven runs the tests, TestModuleConfig is throwing a
> NullPointerException that doesn't show up when running from Ant. I'm
> inclined to believe that the Maven configuration requires more work
> rather that it actually being a problem with ModuleConfig.
>
> The Maven build remains HIGHLY experimental!!
I wonder if we could try a compromise? Could we have a Maven build that
just downloaded the dependencies into the central repository, and a
build.properties that got everything from there. This would save us from
going back to a "struts-library" distribution.
I also wonder if it be possible to wrap our existing Ant build as Maven
goals? The user guide says that any Ant task can be used in the maven.xml.
http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
Another stepping-stone might be to provide Maven projects for the
examples applications, especially the blank application. I'm thinking
the cannonical approach here would be to have a master
webapp-project.xml that we then extended for each application "artifact".
http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
I'm working on a changelog system now but will come back to this later,
if no one beats me to it. [Please do, if you can :)]
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Steve Raeburn <sr...@apache.org>.
I've updated project.xml to reference the validator 1.1.1 jar. You need
to manually download it from http://www.apache.org/~rleland/ and place
it in your local repository.
.maven
plugins
repository
...
commons-validator <-- you may need to create directories below here
jars
commons-validator-1.1.1-dev.jar
maven jar then works (at least for me :-))
There were no tests found because the test section was commented out!
(and the example include pattern doesn't match our naming convention).
I've enabled the JUnit tests. Using Cactus with Maven is beyond me, for
now :-)
When Maven runs the tests, TestModuleConfig is throwing a
NullPointerException that doesn't show up when running from Ant. I'm
inclined to believe that the Maven configuration requires more work
rather that it actually being a problem with ModuleConfig.
The Maven build remains HIGHLY experimental!!
Steve
> -----Original Message-----
> From: Martin Cooper [mailto:martinc@apache.org]
> Sent: November 28, 2003 12:05 AM
> To: Struts Developers List
> Subject: Re: Maven test run
>
>
> After copying my local Validator build to Maven's repo, I get
> the same as
> you do - no tests to run.
>
> Doing the Ant test.junit thing, I get the
> TestActionConfigMatcher failure,
> but it looks like Steve has tracked that one down.
>
> --
> Martin Cooper
>
>
> On Thu, 27 Nov 2003, James Mitchell wrote:
>
> > On Thu, 27 Nov 2003, Ted Husted wrote:
> >
> > > When I run the maven jar target, the upload tests fail
> > > (MultipartTestSuite).
> >
> > On a fresh copy of....well....everything (maven 1.0-rc1,
> jakarta-struts,
> > etc, etc) I cannot do anything with maven.
> >
> > The attempt to download validator SNAPSHOT fails. When I change
> > project.xml to use 1.0.1 or 1.0.2, it downloads, but the
> compile fails
> > complaining about missing ValidatorUtils.
> >
> > I downloaded a nightly, moved it to
> > ~/.maven/repository/commons-validator/jars/.
> >
> > Then changed "SNAPSHOT" to "nightly" in project.xml.
> >
> > Then this:
> >
> > [jmitchell@localhost jakarta-struts]$ maven jar
> > __ __
> > | \/ |__ _Apache__ ___
> > | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
> > |_| |_\__,_|\_/\___|_||_| v. 1.0-rc1-SNAPSHOT
> >
> > java:prepare-filesystem:
> >
> > java:compile:
> > [echo] Compiling to m-target/classes
> > [javac] Compiling 266 source files to
> > /home/jmitchell/cvs/jakarta-struts/m-target/classes
> >
> /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts
> /tiles/actions/DefinitionDispatcherAction.java:78:
> > warning: org.apache.struts.tiles.DefinitionsUtil in
> > org.apache.struts.tiles has been deprecated
> > import org.apache.struts.tiles.DefinitionsUtil;
> > ^
> >
> > <huge-snip/>
> >
> >
> >
> /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts
> /validator/ValidatorPlugIn.java:264:
> > warning:
> org.apache.commons.validator.ValidatorResourcesInitializer in
> > org.apache.commons.validator has been deprecated
> >
> ValidatorResourcesInitializer.initialize(resources,
> > bis, false);
> > ^
> > 41 warnings
> >
> > java:jar-resources:
> > Copying 15 files to
> /home/jmitchell/cvs/jakarta-struts/m-target/classes
> >
> > test:prepare-filesystem:
> > [mkdir] Created dir:
> > /home/jmitchell/cvs/jakarta-struts/m-target/test-classes
> > [mkdir] Created dir:
> > /home/jmitchell/cvs/jakarta-struts/m-target/test-reports
> >
> > test:test-resources:
> >
> > test:compile:
> > [echo] No test source files to compile.
> >
> > test:test:
> > [echo] No tests to run.
> >
> > jar:jar:
> > [jar] Building jar:
> > /home/jmitchell/cvs/jakarta-struts/m-target/struts-1.2.0.jar
> > BUILD SUCCESSFUL
> > Total time: 26 seconds
> > Finished at: Fri Nov 28 01:40:35 EST 2003
> >
> >
> >
> >
> >
> > "No tests to run"....Am I missing something here?
> >
> >
> >
> >
> > >
> > > But, when I run the ant test.junit test, only the
> > > TestActionConfigMatcher test fails.
> > >
> > > Is it me, or do others share this experience?
> > >
> > > If so, any ideas as to why this would be?
> > >
> > > -Ted.
> > >
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> struts-dev-help@jakarta.apache.org
> > >
> > >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Martin Cooper <ma...@apache.org>.
After copying my local Validator build to Maven's repo, I get the same as
you do - no tests to run.
Doing the Ant test.junit thing, I get the TestActionConfigMatcher failure,
but it looks like Steve has tracked that one down.
--
Martin Cooper
On Thu, 27 Nov 2003, James Mitchell wrote:
> On Thu, 27 Nov 2003, Ted Husted wrote:
>
> > When I run the maven jar target, the upload tests fail
> > (MultipartTestSuite).
>
> On a fresh copy of....well....everything (maven 1.0-rc1, jakarta-struts,
> etc, etc) I cannot do anything with maven.
>
> The attempt to download validator SNAPSHOT fails. When I change
> project.xml to use 1.0.1 or 1.0.2, it downloads, but the compile fails
> complaining about missing ValidatorUtils.
>
> I downloaded a nightly, moved it to
> ~/.maven/repository/commons-validator/jars/.
>
> Then changed "SNAPSHOT" to "nightly" in project.xml.
>
> Then this:
>
> [jmitchell@localhost jakarta-struts]$ maven jar
> __ __
> | \/ |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
> |_| |_\__,_|\_/\___|_||_| v. 1.0-rc1-SNAPSHOT
>
> java:prepare-filesystem:
>
> java:compile:
> [echo] Compiling to m-target/classes
> [javac] Compiling 266 source files to
> /home/jmitchell/cvs/jakarta-struts/m-target/classes
> /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/tiles/actions/DefinitionDispatcherAction.java:78:
> warning: org.apache.struts.tiles.DefinitionsUtil in
> org.apache.struts.tiles has been deprecated
> import org.apache.struts.tiles.DefinitionsUtil;
> ^
>
> <huge-snip/>
>
>
> /home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/validator/ValidatorPlugIn.java:264:
> warning: org.apache.commons.validator.ValidatorResourcesInitializer in
> org.apache.commons.validator has been deprecated
> ValidatorResourcesInitializer.initialize(resources,
> bis, false);
> ^
> 41 warnings
>
> java:jar-resources:
> Copying 15 files to /home/jmitchell/cvs/jakarta-struts/m-target/classes
>
> test:prepare-filesystem:
> [mkdir] Created dir:
> /home/jmitchell/cvs/jakarta-struts/m-target/test-classes
> [mkdir] Created dir:
> /home/jmitchell/cvs/jakarta-struts/m-target/test-reports
>
> test:test-resources:
>
> test:compile:
> [echo] No test source files to compile.
>
> test:test:
> [echo] No tests to run.
>
> jar:jar:
> [jar] Building jar:
> /home/jmitchell/cvs/jakarta-struts/m-target/struts-1.2.0.jar
> BUILD SUCCESSFUL
> Total time: 26 seconds
> Finished at: Fri Nov 28 01:40:35 EST 2003
>
>
>
>
>
> "No tests to run"....Am I missing something here?
>
>
>
>
> >
> > But, when I run the ant test.junit test, only the
> > TestActionConfigMatcher test fails.
> >
> > Is it me, or do others share this experience?
> >
> > If so, any ideas as to why this would be?
> >
> > -Ted.
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by James Mitchell <jm...@apache.org>.
On Thu, 27 Nov 2003, Ted Husted wrote:
> When I run the maven jar target, the upload tests fail
> (MultipartTestSuite).
On a fresh copy of....well....everything (maven 1.0-rc1, jakarta-struts,
etc, etc) I cannot do anything with maven.
The attempt to download validator SNAPSHOT fails. When I change
project.xml to use 1.0.1 or 1.0.2, it downloads, but the compile fails
complaining about missing ValidatorUtils.
I downloaded a nightly, moved it to
~/.maven/repository/commons-validator/jars/.
Then changed "SNAPSHOT" to "nightly" in project.xml.
Then this:
[jmitchell@localhost jakarta-struts]$ maven jar
__ __
| \/ |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \ ~ intelligent projects ~
|_| |_\__,_|\_/\___|_||_| v. 1.0-rc1-SNAPSHOT
java:prepare-filesystem:
java:compile:
[echo] Compiling to m-target/classes
[javac] Compiling 266 source files to
/home/jmitchell/cvs/jakarta-struts/m-target/classes
/home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/tiles/actions/DefinitionDispatcherAction.java:78:
warning: org.apache.struts.tiles.DefinitionsUtil in
org.apache.struts.tiles has been deprecated
import org.apache.struts.tiles.DefinitionsUtil;
^
<huge-snip/>
/home/jmitchell/cvs/jakarta-struts/src/share/org/apache/struts/validator/ValidatorPlugIn.java:264:
warning: org.apache.commons.validator.ValidatorResourcesInitializer in
org.apache.commons.validator has been deprecated
ValidatorResourcesInitializer.initialize(resources,
bis, false);
^
41 warnings
java:jar-resources:
Copying 15 files to /home/jmitchell/cvs/jakarta-struts/m-target/classes
test:prepare-filesystem:
[mkdir] Created dir:
/home/jmitchell/cvs/jakarta-struts/m-target/test-classes
[mkdir] Created dir:
/home/jmitchell/cvs/jakarta-struts/m-target/test-reports
test:test-resources:
test:compile:
[echo] No test source files to compile.
test:test:
[echo] No tests to run.
jar:jar:
[jar] Building jar:
/home/jmitchell/cvs/jakarta-struts/m-target/struts-1.2.0.jar
BUILD SUCCESSFUL
Total time: 26 seconds
Finished at: Fri Nov 28 01:40:35 EST 2003
"No tests to run"....Am I missing something here?
>
> But, when I run the ant test.junit test, only the
> TestActionConfigMatcher test fails.
>
> Is it me, or do others share this experience?
>
> If so, any ideas as to why this would be?
>
> -Ted.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
--
James Mitchell
Software Developer / Struts Evangelist
http://www.struts-atlanta.org
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Steve Raeburn <sr...@apache.org>.
Me too!
Steve
> -----Original Message-----
> From: Martin Cooper [mailto:martinc@apache.org]
> Sent: November 28, 2003 12:56 AM
> To: Struts Developers List
> Subject: RE: Maven test run
>
>
> On Thu, 27 Nov 2003 mrdon@twdata.org wrote:
>
> > Good point, thanks for solving the mystery. I've updated
> the test to not
> > depend on the hashmap order.
>
> Cool. Works for me. :-)
>
> --
> Martin Cooper
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Martin Cooper <ma...@apache.org>.
On Thu, 27 Nov 2003 mrdon@twdata.org wrote:
> Good point, thanks for solving the mystery. I've updated the test to not
> depend on the hashmap order.
Cool. Works for me. :-)
--
Martin Cooper
>
> Don
>
> > I'm also getting a failure on TestActionConfigMatcher (using Ant build):
> >
> > Name isn't correct
> > junit.framework.AssertionFailedError: Name isn't correct
> > at
> > org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM
> > atch(TestActionConfigMatcher.java:202)
> > ...
> >
> > cfg.getName() is returning 'name2', but the test expects 'name'
> >
> > fConfigs contains:
> > [0] = name2
> > [1] = name
> >
> > The problem seems to be that the test relies on the order of the array
> > elements but ActionConfig stores the configs in a HashMap which does not
> > return its values collection in a guaranteed order. I would have
> > expected the failure to be intermittent, but it fails consistently for
> > me. Maybe in practice the order is consistent for a platform, JDK, day
> > of the week etc. etc. :-)
> >
> > As an experiment, I changed the HashMap to a TreeMap, and the tests
> > pass. I don't know if this would have any knock on effects elsewhere
> > though. Might be better to rethink the test so it doesn't rely on the
> > ordering. Or even just drop that section since it's really only testing
> > findForwardConfigs(), not the matcher.
> >
> >
> > Steve
> >
> >
> >
> >> -----Original Message-----
> >> From: Don Brown [mailto:mrdon@twdata.org]
> >> Sent: November 27, 2003 9:36 PM
> >> To: Struts Developers List
> >> Subject: Re: Maven test run
> >>
> >>
> >> Hmmm...I just updated, uncommented those two lines, and ran "ant
> >> test.junit" - all tests passed. Anyone else?
> >>
> >> Don
> >>
> >> On Thu, 27 Nov 2003, Ted Husted wrote:
> >>
> >> > When I run the maven jar target, the upload tests fail
> >> > (MultipartTestSuite).
> >> >
> >> > But, when I run the ant test.junit test, only the
> >> > TestActionConfigMatcher test fails.
> >> >
> >> > Is it me, or do others share this experience?
> >> >
> >> > If so, any ideas as to why this would be?
> >> >
> >> > -Ted.
> >> >
> >> >
> >> >
> >> >
> >> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >> >
> >> >
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >>
> >>
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by mr...@twdata.org.
Good point, thanks for solving the mystery. I've updated the test to not
depend on the hashmap order.
Don
> I'm also getting a failure on TestActionConfigMatcher (using Ant build):
>
> Name isn't correct
> junit.framework.AssertionFailedError: Name isn't correct
> at
> org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM
> atch(TestActionConfigMatcher.java:202)
> ...
>
> cfg.getName() is returning 'name2', but the test expects 'name'
>
> fConfigs contains:
> [0] = name2
> [1] = name
>
> The problem seems to be that the test relies on the order of the array
> elements but ActionConfig stores the configs in a HashMap which does not
> return its values collection in a guaranteed order. I would have
> expected the failure to be intermittent, but it fails consistently for
> me. Maybe in practice the order is consistent for a platform, JDK, day
> of the week etc. etc. :-)
>
> As an experiment, I changed the HashMap to a TreeMap, and the tests
> pass. I don't know if this would have any knock on effects elsewhere
> though. Might be better to rethink the test so it doesn't rely on the
> ordering. Or even just drop that section since it's really only testing
> findForwardConfigs(), not the matcher.
>
>
> Steve
>
>
>
>> -----Original Message-----
>> From: Don Brown [mailto:mrdon@twdata.org]
>> Sent: November 27, 2003 9:36 PM
>> To: Struts Developers List
>> Subject: Re: Maven test run
>>
>>
>> Hmmm...I just updated, uncommented those two lines, and ran "ant
>> test.junit" - all tests passed. Anyone else?
>>
>> Don
>>
>> On Thu, 27 Nov 2003, Ted Husted wrote:
>>
>> > When I run the maven jar target, the upload tests fail
>> > (MultipartTestSuite).
>> >
>> > But, when I run the ant test.junit test, only the
>> > TestActionConfigMatcher test fails.
>> >
>> > Is it me, or do others share this experience?
>> >
>> > If so, any ideas as to why this would be?
>> >
>> > -Ted.
>> >
>> >
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>>
>>
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
RE: Maven test run
Posted by Steve Raeburn <sr...@apache.org>.
I'm also getting a failure on TestActionConfigMatcher (using Ant build):
Name isn't correct
junit.framework.AssertionFailedError: Name isn't correct
at
org.apache.struts.config.TestActionConfigMatcher.testCheckSubstitutionsM
atch(TestActionConfigMatcher.java:202)
...
cfg.getName() is returning 'name2', but the test expects 'name'
fConfigs contains:
[0] = name2
[1] = name
The problem seems to be that the test relies on the order of the array
elements but ActionConfig stores the configs in a HashMap which does not
return its values collection in a guaranteed order. I would have
expected the failure to be intermittent, but it fails consistently for
me. Maybe in practice the order is consistent for a platform, JDK, day
of the week etc. etc. :-)
As an experiment, I changed the HashMap to a TreeMap, and the tests
pass. I don't know if this would have any knock on effects elsewhere
though. Might be better to rethink the test so it doesn't rely on the
ordering. Or even just drop that section since it's really only testing
findForwardConfigs(), not the matcher.
Steve
> -----Original Message-----
> From: Don Brown [mailto:mrdon@twdata.org]
> Sent: November 27, 2003 9:36 PM
> To: Struts Developers List
> Subject: Re: Maven test run
>
>
> Hmmm...I just updated, uncommented those two lines, and ran "ant
> test.junit" - all tests passed. Anyone else?
>
> Don
>
> On Thu, 27 Nov 2003, Ted Husted wrote:
>
> > When I run the maven jar target, the upload tests fail
> > (MultipartTestSuite).
> >
> > But, when I run the ant test.junit test, only the
> > TestActionConfigMatcher test fails.
> >
> > Is it me, or do others share this experience?
> >
> > If so, any ideas as to why this would be?
> >
> > -Ted.
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org
Re: Maven test run
Posted by Don Brown <mr...@twdata.org>.
Hmmm...I just updated, uncommented those two lines, and ran "ant
test.junit" - all tests passed. Anyone else?
Don
On Thu, 27 Nov 2003, Ted Husted wrote:
> When I run the maven jar target, the upload tests fail
> (MultipartTestSuite).
>
> But, when I run the ant test.junit test, only the
> TestActionConfigMatcher test fails.
>
> Is it me, or do others share this experience?
>
> If so, any ideas as to why this would be?
>
> -Ted.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org