You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/09 03:21:17 UTC
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #500: Remove
the additional apps checkout step for PR check job
liuguo09 opened a new pull request #500: Remove the additional apps checkout step for PR check job
URL: https://github.com/apache/incubator-nuttx/pull/500
Remove the apps checkout step to save check job time.
Signed-off-by: liuhaitao <li...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #500: Remove the
additional apps checkout step for PR check job
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #500: Remove the additional apps checkout step for PR check job
URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596522592
Was this redundant? How do we check that the PR's nuttx builds with apps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #500: Remove
the additional apps checkout step for PR check job
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #500: Remove the additional apps checkout step for PR check job
URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596553421
> Was this redundant? How do we check that the PR's nuttx builds with apps?
This step is ust for checking style/spell..., it's enough to only fetch nuttx git, the build step will fetch both nuttx/apps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #500: Remove the
additional apps checkout step for PR check job
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #500: Remove the additional apps checkout step for PR check job
URL: https://github.com/apache/incubator-nuttx/pull/500#issuecomment-596554672
Yes, apps checkout step in nuttx PR check job is redundant. However, nuttx checkout step in apps PR check job is necessary since nuttx/tools/checkpatch.sh in need at first, as https://github.com/apache/incubator-nuttx-apps/pull/113 shows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #500: Remove
the additional apps checkout step for PR check job
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #500: Remove the additional apps checkout step for PR check job
URL: https://github.com/apache/incubator-nuttx/pull/500
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services