You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2015/05/29 17:06:55 UTC
[4/4] camel git commit: CAMEL-8812 Added the
HL7MLLPNettyDecoderResourceLeakTest file
CAMEL-8812 Added the HL7MLLPNettyDecoderResourceLeakTest file
Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/b2188887
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/b2188887
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/b2188887
Branch: refs/heads/camel-2.15.x
Commit: b2188887abddb08aae39541112e6912509a69117
Parents: 38a856d
Author: Willem Jiang <wi...@gmail.com>
Authored: Fri May 29 23:05:08 2015 +0800
Committer: Willem Jiang <wi...@gmail.com>
Committed: Fri May 29 23:06:27 2015 +0800
----------------------------------------------------------------------
.../component/hl7/HL7MLLPNettyDecoder.java | 1 +
.../HL7MLLPNettyDecoderResourceLeakTest.java | 69 ++++++++++++++++++++
2 files changed, 70 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/camel/blob/b2188887/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoder.java
----------------------------------------------------------------------
diff --git a/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoder.java b/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoder.java
index 9c04448..2ced9b4 100644
--- a/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoder.java
+++ b/components/camel-hl7/src/main/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoder.java
@@ -69,6 +69,7 @@ class HL7MLLPNettyDecoder extends DelimiterBasedFrameDecoder {
throw new DecoderException("Did not find start byte " + (int) config.getStartByte());
}
} finally {
+ // We need to release the buf here to avoid the memory leak
buf.release();
}
}
http://git-wip-us.apache.org/repos/asf/camel/blob/b2188887/components/camel-hl7/src/test/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoderResourceLeakTest.java
----------------------------------------------------------------------
diff --git a/components/camel-hl7/src/test/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoderResourceLeakTest.java b/components/camel-hl7/src/test/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoderResourceLeakTest.java
new file mode 100644
index 0000000..81cee04
--- /dev/null
+++ b/components/camel-hl7/src/test/java/org/apache/camel/component/hl7/HL7MLLPNettyDecoderResourceLeakTest.java
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.hl7;
+
+import ca.uhn.hl7v2.model.Message;
+import io.netty.util.ResourceLeakDetector;
+import org.apache.camel.Exchange;
+import org.apache.camel.Processor;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.impl.JndiRegistry;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class HL7MLLPNettyDecoderResourceLeakTest extends HL7TestSupport {
+
+ @BeforeClass
+ // As the ResourceLeakDetector just write error log when it find the leak,
+ // We need to check the log file to see if there is a leak.
+ public static void enableNettyResourceLeakDetector() {
+ ResourceLeakDetector.setLevel(ResourceLeakDetector.Level.PARANOID);
+ }
+
+ protected JndiRegistry createRegistry() throws Exception {
+ JndiRegistry jndi = super.createRegistry();
+
+ jndi.bind("hl7decoder", new HL7MLLPNettyDecoderFactory());
+ jndi.bind("hl7encoder", new HL7MLLPNettyEncoderFactory());
+
+ return jndi;
+ }
+
+ protected RouteBuilder createRouteBuilder() throws Exception {
+ return new RouteBuilder() {
+ public void configure() throws Exception {
+ from("netty4:tcp://127.0.0.1:" + getPort() + "?decoder=#hl7decoder&encoder=#hl7encoder")
+ .process(new Processor() {
+ public void process(Exchange exchange) throws Exception {
+ Message input = exchange.getIn().getBody(Message.class);
+ exchange.getOut().setBody(input.generateACK());
+ }
+ })
+ .to("mock:result");
+ }
+ };
+ }
+
+ @Test
+ public void testSendHL7Message() throws Exception {
+ String message = "MSH|^~\\&|MYSENDER|MYRECEIVER|MYAPPLICATION||200612211200||QRY^A19|1234|P|2.4";
+
+ for (int i = 0; i < 10; i++) {
+ template.sendBody("netty4:tcp://127.0.0.1:" + getPort() + "?decoder=#hl7decoder&encoder=#hl7encoder", message);
+ }
+ }
+}