[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4520: refactor: make Ctes a struct to also store data types provided by prepare stmt

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4520:
URL: https://github.com/apache/arrow-datafusion/pull/4520#discussion_r1040843955


##########
datafusion/sql/src/planner.rs:
##########
@@ -103,6 +103,31 @@ pub struct ParserOptions {
     parse_float_as_decimal: bool,
 }
 
+#[derive(Debug, Clone)]
+/// Struct to store Common Table Expression provided with WITH clause and Parameter Data Types provided with PREPARE statement

Review Comment:
   ```suggestion
   /// Struct to store Common Table Expression (CTE) provided with WITH clause and Parameter Data Types provided with PREPARE statement
   ```



##########
datafusion/sql/src/planner.rs:
##########
@@ -103,6 +103,31 @@ pub struct ParserOptions {
     parse_float_as_decimal: bool,
 }
 
+#[derive(Debug, Clone)]
+/// Struct to store Common Table Expression provided with WITH clause and Parameter Data Types provided with PREPARE statement
+pub struct Ctes {

Review Comment:
   What do you think about calling this `PlannerState` or `PlannerContext` rather than `Ctes` as will contain more than CTEs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org