You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/03 09:52:36 UTC
[GitHub] spark pull request #22616: [SPARK-25586][Core] Remove outer objects from log...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22616#discussion_r222249333
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -341,7 +340,7 @@ private[spark] object ClosureCleaner extends Logging {
// Clone the closure objects themselves, nulling out any fields that are not
// used in the closure we're working on or any of its inner closures.
for ((cls, obj) <- outerPairs) {
- logDebug(s" + cloning the object $obj of class ${cls.getName}")
+ logDebug(s" + cloning the object of class ${cls.getName}")
--- End diff --
Nit: maybe "cloning instance of class .."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org