You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/03/20 19:07:20 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #3993: In
TableConfig, add checks for mandatory fields
codecov-io commented on issue #3993: In TableConfig, add checks for mandatory fields
URL: https://github.com/apache/incubator-pinot/pull/3993#issuecomment-474986968
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=h1) Report
> Merging [#3993](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/59fd4aab4480b6c62ba0bfe61f1a976d0ca31221?src=pr&el=desc) will **decrease** coverage by `6.5%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3993/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3993 +/- ##
============================================
- Coverage 56.98% 50.48% -6.51%
Complexity 4 4
============================================
Files 1032 1155 +123
Lines 51124 58088 +6964
Branches 7135 8046 +911
============================================
+ Hits 29135 29325 +190
- Misses 19832 26597 +6765
- Partials 2157 2166 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `69.54% <100%> (+1.94%)` | `0 <0> (ø)` | :arrow_down: |
| [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9FbXB0eUJyb2tlck9ubGluZU9mZmxpbmVTdGF0ZU1vZGVsRmFjdG9yeS5qYXZh) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [.../startree/v2/builder/OffHeapSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL09mZkhlYXBTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `86.3% <0%> (-4.17%)` | `0% <0%> (ø)` | |
| [...n/java/org/apache/pinot/tools/SegmentDumpTool.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL1NlZ21lbnREdW1wVG9vbC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...segment/converter/PinotSegmentToJsonConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NlZ21lbnQvY29udmVydGVyL1Bpbm90U2VnbWVudFRvSnNvbkNvbnZlcnRlci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...apache/pinot/tools/scan/query/AggregationFunc.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3NjYW4vcXVlcnkvQWdncmVnYXRpb25GdW5jLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...t/tools/config/validator/TableConfigValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2NvbmZpZy92YWxpZGF0b3IvVGFibGVDb25maWdWYWxpZGF0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...s/admin/command/BackfillDateTimeColumnCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQmFja2ZpbGxEYXRlVGltZUNvbHVtbkNvbW1hbmQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...g/apache/pinot/tools/perf/PerfBenchmarkRunner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3BlcmYvUGVyZkJlbmNobWFya1J1bm5lci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| ... and [121 more](https://codecov.io/gh/apache/incubator-pinot/pull/3993/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=footer). Last update [59fd4aa...a409684](https://codecov.io/gh/apache/incubator-pinot/pull/3993?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org