You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Raju Bairishetti <ra...@gmail.com> on 2015/01/25 09:54:18 UTC
Review Request 30250: LENS-186: notify session lifecycle events
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 29, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java, line 32
> > <https://reviews.apache.org/r/30250/diff/2/?file=833448#file833448line32>
> >
> > why don't we have user here?
Looks like, LensServer does not use any user information for closing the sessions.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69988
-----------------------------------------------------------
On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 1:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 29, 2015, 12:08 p.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 237
> > <https://reviews.apache.org/r/30250/diff/2/?file=833453#file833453line237>
> >
> > maybe we can add a method `notifyEvent` in LensServices itself so as to remove code duplication. Doing that, `getEventService` will only be called inside `notifyEvent` and then that function's code can directly be put inside `notifyEvent` instead of separate function. Subclasses will need to be modified accordingly.
Refactor the code
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69988
-----------------------------------------------------------
On April 29, 2015, 3:48 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 3:48 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69988
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java
<https://reviews.apache.org/r/30250/#comment114907>
why don't we have user here?
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment114908>
import order is wrong. Pull master and put up the review request again. refer to https://issues.apache.org/jira/browse/LENS-205
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment114913>
maybe we can add a method `notifyEvent` in LensServices itself so as to remove code duplication. Doing that, `getEventService` will only be called inside `notifyEvent` and then that function's code can directly be put inside `notifyEvent` instead of separate function. Subclasses will need to be modified accordingly.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/30250/#comment114910>
This should be inherited from LensService.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/30250/#comment114909>
Why are we removing NPE?
- Rajat Khandelwal
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 25, 2015, 11:40 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, line 414
> > <https://reviews.apache.org/r/30250/diff/2/?file=833455#file833455line414>
> >
> > Should this different from SessionClosed event? or Should extend SessionClosed ?
I think we should extend SessionClosed. SessionExpired is used to diffrentiate between the inactive sessions and the session which is closed by user. Actually, I am sending both events for the expired sessions(inactive), which is not required.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69560
-----------------------------------------------------------
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 25, 2015, 11:40 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java, line 46
> > <https://reviews.apache.org/r/30250/diff/2/?file=833449#file833449line46>
> >
> > What is this id for?
This is a unique id to indicate/identify the event.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69560
-----------------------------------------------------------
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69560
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment114259>
should be abstract?
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment114265>
What is this id for?
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment114266>
Why is this constructor required?
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment114267>
Can you use toString from lombok itslef?
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java
<https://reviews.apache.org/r/30250/#comment114268>
SessionEvent already has user. Why is this required here?
May be we should only have it here and remove from SessionEvent
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
<https://reviews.apache.org/r/30250/#comment114269>
Should this different from SessionClosed event? or Should extend SessionClosed ?
We should also add metrics - counters for how sessions opened, closed and gauge for current open sessions. Can be part of this jira or a separate jira is fine too.
- Amareshwari Sriramadasu
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 23, 2015, 12:30 p.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java, line 165
> > <https://reviews.apache.org/r/30250/diff/3/?file=939000#file939000line165>
> >
> > rename this to something like `getSessionsOpenedTillNow`?
>
> Raju Bairishetti wrote:
> I think getSessionsOpened**TillNow** conveys how many sessions were opened from the start of server instead of how many sessions are active(opened) at that moment.
Then please provide javadoc for the new methods added. I might have misunderstood.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81275
-----------------------------------------------------------
On April 24, 2015, 5:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 24, 2015, 5:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, line 213
> > <https://reviews.apache.org/r/30250/diff/3/?file=939007#file939007line213>
> >
> > `openedSessions.inc()`
openedSessions is a guage metric. It gets the value from SESSION_MAP
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 160
> > <https://reviews.apache.org/r/30250/diff/3/?file=939006#file939006line160>
> >
> > Let's not make extra method for just one service. Since corresponding methods for other services are not there. Plus it doesn't make sense to return an instance of a subclass from a superclass.
This is an existing getter method in QueryExecutionServiceImpl. I just moved the method to here to make it available to SessionService as well.
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java, line 49
> > <https://reviews.apache.org/r/30250/diff/3/?file=939004#file939004line49>
> >
> > can have
> >
> > @Getter private SessionStatus sessionStatus = SessionStatus.OPENED
> >
> > instead of overriding. Will save 4 lines.
+1
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81275
-----------------------------------------------------------
On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 1:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensService.java, line 79
> > <https://reviews.apache.org/r/30250/diff/3/?file=939006#file939006line79>
> >
> > Why make it public?
Reverted to protected. Added a getter for only getting the numberofSessions.
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java, line 165
> > <https://reviews.apache.org/r/30250/diff/3/?file=939000#file939000line165>
> >
> > rename this to something like `getSessionsOpenedTillNow`?
I think getSessionsOpened**TillNow** conveys how many sessions were opened from the start of server instead of how many sessions are active(opened) at that moment.
> On April 23, 2015, 7 a.m., Rajat Khandelwal wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java, line 261
> > <https://reviews.apache.org/r/30250/diff/3/?file=939010#file939010line261>
> >
> > Instead of keeping a boolean, should we keep an integer so that we can verify how many times the function was hit.
The events are generated from the unit test itself. We are calling only once. It just tests the event listener like Whether events are received when they triggered.
We have a unit test for session metrics.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81275
-----------------------------------------------------------
On April 23, 2015, 11:52 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 11:52 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81275
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java
<https://reviews.apache.org/r/30250/#comment131566>
rename this to something like `getSessionsOpenedTillNow`?
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment131567>
Don't need `()`
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java
<https://reviews.apache.org/r/30250/#comment131568>
can have
@Getter private SessionStatus sessionStatus = SessionStatus.OPENED
instead of overriding. Will save 4 lines.
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment131569>
Why make it public?
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment131570>
Let's not make extra method for just one service. Since corresponding methods for other services are not there. Plus it doesn't make sense to return an instance of a subclass from a superclass.
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment131571>
This call shouldn't be in `LensService`, it should be in `HiveSessionService`
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131572>
Don't need an extra call. Can merge the called function here itself.
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131573>
`openedSessions.inc()`
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131575>
Also, `openedSessions.inc()`
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131576>
also, `openedSessions.dec()`
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131577>
+1
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java
<https://reviews.apache.org/r/30250/#comment131578>
Instead of keeping a boolean, should we keep an integer so that we can verify how many times the function was hit.
- Rajat Khandelwal
On April 22, 2015, 6:52 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 6:52 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81286
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment131595>
Made it public for accessing from MetricServiceImpl to know the number of sessions opened (gauge metric)
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment131593>
This is an existing getter method in QueryExecutionServiceImpl. I just moved the method to here to make it available to SessionService as well.
- Raju Bairishetti
On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 1:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 27, 2015, 11:59 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java, line 33
> > <https://reviews.apache.org/r/30250/diff/5/?file=942606#file942606line33>
> >
> > Is this required? How is CLOSED state different from EXPIRED? From state transitions, they are the same.
> >
> > Similar OPEN and RESTORE are the same.
> >
> > I would say let us remove this status enum.
EXPIRED is added just to know how many sessions were inactive(idle for longer than expired interval) and how many sessions were closed by the users. Eventually, all inactive(expired) sessions will be closed periodically.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81674
-----------------------------------------------------------
On April 28, 2015, 1:47 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 1:47 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java cec7343
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ed906fe
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81674
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java
<https://reviews.apache.org/r/30250/#comment132104>
Is this required? How is CLOSED state different from EXPIRED? From state transitions, they are the same.
Similar OPEN and RESTORE are the same.
I would say let us remove this status enum.
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment132102>
Shall we add one counter for expired sessions to know how many session sessions are being left idle for more than expiry interval
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment132103>
This should include expired as well.
- Amareshwari Sriramadasu
On April 27, 2015, 2:43 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 2:43 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On April 29, 2015, 5:02 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java, line 120
> > <https://reviews.apache.org/r/30250/diff/8/?file=944705#file944705line120>
> >
> > Should we call this active open sessions? or something else?
> >
> > totalOpenedSessions - gives total number of OPEN session calls on server since server start.
> >
> > This gauge is all open sessions which are not closed, includes restored sessions as well. can we think of a better name ?
Seems Active sessions is appropriate.
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81927
-----------------------------------------------------------
On April 30, 2015, 2:33 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 2:33 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81927
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment132491>
Should we call this active open sessions? or something else?
totalOpenedSessions - gives total number of OPEN session calls on server since server start.
This gauge is all open sessions which are not closed, includes restored sessions as well. can we think of a better name ?
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
<https://reviews.apache.org/r/30250/#comment132493>
On session expiry, both SessionClosed and SessionExpired events are raised separately?
- Amareshwari Sriramadasu
On April 29, 2015, 4:01 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 4:01 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review82377
-----------------------------------------------------------
One more comment wrt documentation. Please update monitoring doc with new counters added. Sorry missed this earlier.
- Amareshwari Sriramadasu
On April 30, 2015, 3:15 p.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 3:15 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review82629
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On May 6, 2015, 1:27 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 1:27 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
> src/site/apt/admin/monitoring.apt 41c7951
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated May 6, 2015, 1:27 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Updated monitoring doc with new metrics
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
src/site/apt/admin/monitoring.apt 41c7951
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService and TestSessionResource
incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
[INFO] Lens .............................................. SUCCESS [2.922s]
[INFO] Lens API .......................................... SUCCESS [17.324s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
[INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
[INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
[INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
[INFO] Lens Server ....................................... SUCCESS [5:19.086s]
[INFO] Lens client ....................................... SUCCESS [40.811s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
[INFO] Lens Examples ..................................... SUCCESS [9.312s]
[INFO] Lens Distribution ................................. SUCCESS [10.739s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
[INFO] Lens Regression ................................... SUCCESS [0.508s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:29.184s
[INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
[INFO] Final Memory: 116M/1466M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 30, 2015, 3:15 p.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService and TestSessionResource
incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
[INFO] Lens .............................................. SUCCESS [2.922s]
[INFO] Lens API .......................................... SUCCESS [17.324s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
[INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
[INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
[INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
[INFO] Lens Server ....................................... SUCCESS [5:19.086s]
[INFO] Lens client ....................................... SUCCESS [40.811s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
[INFO] Lens Examples ..................................... SUCCESS [9.312s]
[INFO] Lens Distribution ................................. SUCCESS [10.739s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
[INFO] Lens Regression ................................... SUCCESS [0.508s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:29.184s
[INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
[INFO] Final Memory: 116M/1466M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review82126
-----------------------------------------------------------
Ship it!
Update test result with latest changes.
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
<https://reviews.apache.org/r/30250/#comment132822>
javadoc needs change
- Amareshwari Sriramadasu
On April 30, 2015, 11:54 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 11:54 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 30, 2015, 11:54 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
addressed the review comments
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService and TestSessionResource
incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
[INFO] Lens .............................................. SUCCESS [2.922s]
[INFO] Lens API .......................................... SUCCESS [17.324s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
[INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
[INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
[INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
[INFO] Lens Server ....................................... SUCCESS [5:19.086s]
[INFO] Lens client ....................................... SUCCESS [40.811s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
[INFO] Lens Examples ..................................... SUCCESS [9.312s]
[INFO] Lens Distribution ................................. SUCCESS [10.739s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
[INFO] Lens Regression ................................... SUCCESS [0.508s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:29.184s
[INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
[INFO] Final Memory: 116M/1466M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review82098
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment132765>
Why are we decrementing this? totalOpenedSessions would indicating how many open sessions happened. Not active sessions.
Similar to totalAcceptedQueries, we shouldnt decrement it.
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
<https://reviews.apache.org/r/30250/#comment132766>
This might be named closeInternal and called from above method as well.
- Amareshwari Sriramadasu
On April 30, 2015, 2:33 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 2:33 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService and TestSessionResource
>
> incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
> [INFO] Lens .............................................. SUCCESS [2.922s]
> [INFO] Lens API .......................................... SUCCESS [17.324s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
> [INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
> [INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
> [INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
> [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
> [INFO] Lens Server ....................................... SUCCESS [5:19.086s]
> [INFO] Lens client ....................................... SUCCESS [40.811s]
> [INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
> [INFO] Lens Examples ..................................... SUCCESS [9.312s]
> [INFO] Lens Distribution ................................. SUCCESS [10.739s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
> [INFO] Lens Regression ................................... SUCCESS [0.508s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 25:29.184s
> [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
> [INFO] Final Memory: 116M/1466M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 30, 2015, 2:33 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService and TestSessionResource
incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
[INFO] Lens .............................................. SUCCESS [2.922s]
[INFO] Lens API .......................................... SUCCESS [17.324s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
[INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
[INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
[INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
[INFO] Lens Server ....................................... SUCCESS [5:19.086s]
[INFO] Lens client ....................................... SUCCESS [40.811s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
[INFO] Lens Examples ..................................... SUCCESS [9.312s]
[INFO] Lens Distribution ................................. SUCCESS [10.739s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
[INFO] Lens Regression ................................... SUCCESS [0.508s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:29.184s
[INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
[INFO] Final Memory: 116M/1466M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 29, 2015, 4:01 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing (updated)
-------
Added a unit test in TestEventService and TestSessionResource
incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s]
[INFO] Lens .............................................. SUCCESS [2.922s]
[INFO] Lens API .......................................... SUCCESS [17.324s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.467s]
[INFO] Lens Cube ......................................... SUCCESS [4:14.366s]
[INFO] Lens DB storage ................................... SUCCESS [1:03.938s]
[INFO] Lens Query Library ................................ SUCCESS [1:00.936s]
[INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s]
[INFO] Lens Server ....................................... SUCCESS [5:19.086s]
[INFO] Lens client ....................................... SUCCESS [40.811s]
[INFO] Lens CLI .......................................... SUCCESS [2:47.861s]
[INFO] Lens Examples ..................................... SUCCESS [9.312s]
[INFO] Lens Distribution ................................. SUCCESS [10.739s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s]
[INFO] Lens Regression ................................... SUCCESS [0.508s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:29.184s
[INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015
[INFO] Final Memory: 116M/1466M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 29, 2015, 3:48 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
reverted changes in the serviceResource interface and added asserts for the session expirymetric
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java c1cb9da
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing (updated)
-------
Added a unit test in TestEventService and TestSessionResource
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 28, 2015, 1:47 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java cec7343
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java ed906fe
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 28, 2015, 1:31 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
addressed review comments
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 27, 2015, 2:43 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Fix unit test and check style errors
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 23, 2015, 11:52 p.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Review comments incorporated
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review81285
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java
<https://reviews.apache.org/r/30250/#comment131592>
openedSessions is a guage metric. It gets the value from SESSION_MAP
- Raju Bairishetti
On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 1:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated April 22, 2015, 1:22 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review70196
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensService.java
<https://reviews.apache.org/r/30250/#comment115267>
Ignore. Will be taken care in a later jira.
- Rajat Khandelwal
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
> On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote:
> > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java, line 369
> > <https://reviews.apache.org/r/30250/diff/2/?file=833456#file833456line369>
> >
> > @Raju, Instead of this unit test, we should check if the events are getting generated when sessions are closed/opened. We already have a TestSessionResource. Can we add few testcases for events there?
> >
> > What we are testing here is essentially just event send and receive, that has been already verified in other test cases in this class.
I have added a unit test for validating the session events metrics in TestSessionResource test class. That covers whether session events are getting generated or not.
> On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, line 414
> > <https://reviews.apache.org/r/30250/diff/2/?file=833455#file833455line414>
> >
> > I also think one SessionClosed event is enough. Main motivation behind these events is to allow other services to manage per session resources. From that perspective SessionExpired and SessionClosed are the same.
Did not make any changes with respect to this review comment. Can we have single SessionClosed event for all closing related things(expiring & closing) ?
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69749
-----------------------------------------------------------
On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 1:22 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java 71a1f5b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java 90137e1
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java cd1fbd8
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java e4fb812
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java ec752ff
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 00df104
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote:
> >
`SessionExpired extends SessionClosed`, then any handler on `SessionClosed` will be applied in both cases. This design additionaly allows us to do separate/additional handling for `SessionExpired` events. An even more generic way would be to keep three classes: `SessionEnded`, `SessionExpired`, `SessionClosed` where the latter two extend from the first.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69749
-----------------------------------------------------------
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69749
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
<https://reviews.apache.org/r/30250/#comment114551>
I also think one SessionClosed event is enough. Main motivation behind these events is to allow other services to manage per session resources. From that perspective SessionExpired and SessionClosed are the same.
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java
<https://reviews.apache.org/r/30250/#comment114552>
@Raju, Instead of this unit test, we should check if the events are getting generated when sessions are closed/opened. We already have a TestSessionResource. Can we add few testcases for events there?
What we are testing here is essentially just event send and receive, that has been already verified in other test cases in this class.
- Jaideep dhok
On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2015, 8:56 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-186
> https://issues.apache.org/jira/browse/LENS-186
>
>
> Repository: lens
>
>
> Description
> -------
>
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
>
> This would be also useful in maintaining session history.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
>
> Diff: https://reviews.apache.org/r/30250/diff/
>
>
> Testing
> -------
>
> Added a unit test in TestEventService
>
>
> Thanks,
>
> Raju Bairishetti
>
>
Re: Review Request 30250: LENS-186: notify session lifecycle events
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/
-----------------------------------------------------------
(Updated Jan. 25, 2015, 8:56 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
reorder imports
Bugs: LENS-186
https://issues.apache.org/jira/browse/LENS-186
Repository: lens
Description
-------
If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
This would be also useful in maintaining session history.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02
Diff: https://reviews.apache.org/r/30250/diff/
Testing
-------
Added a unit test in TestEventService
Thanks,
Raju Bairishetti