[jira] [Commented] (HBASE-20623) Introduce the helper method "getCellBuilder()" to Mutation

["Reid Chan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674940#comment-16674940 ] 

Reid Chan commented on HBASE-20623:
-----------------------------------

I think a {{Mutation}} should use one {{CellBuilder}} to create multiple cells.
Following code:
{code}
protected CellBuilder getCellBuilder(CellBuilderType cellBuilderType, Cell.Type cellType) {
	 CellBuilder builder = CellBuilderFactory.create(cellBuilderType).setRow(row).setType(cellType);
	 return new CellBuilder() {
{code}
every time i call {{getCellBuilder}}, mutation will create a new builder to create a cell, not a good practice in case of multiple cells for one put.
In such an assumption(one creates many), it also should use DEEP_COPY.

WDYT, ping [~chia7712]

> Introduce the helper method "getCellBuilder()" to Mutation
> ----------------------------------------------------------
>
>                 Key: HBASE-20623
>                 URL: https://issues.apache.org/jira/browse/HBASE-20623
>             Project: HBase
>          Issue Type: Task
>          Components: API
>            Reporter: Chia-Ping Tsai
>            Assignee: maoling
>            Priority: Minor
>             Fix For: 3.0.0, 2.2.0
>
>         Attachments: HBASE-20623.master.001.patch, HBASE-20623.master.002.patch, HBASE-20623.master.003.patch, HBASE-20623.master.004.patch, HBASE-20623.master.005.patch, HBASE-20623.master.006.patch, HBASE-20623.master.007.patch, HBASE-20623.master.008.patch, HBASE-20623.master.009.patch
>
>
> see [https://lists.apache.org/thread.html/d05bfaa0134502a47f6e1aca56cb0b096d4dd32ddefbbdf28db4952a@%3Cdev.hbase.apache.org%3E] for more details.
> {code:java}
> How about a "getCellBuilder" or "getCellBuilderFactory" method for
> Mutation implementations that gives you a CellBuilder instance that
> already has relevant parts set? Like for a Put instance it should be
> able to already have the Type and Row set.{code}
> mentioned a day or so ago by [~busbey]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)