You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "betodealmeida (via GitHub)" <gi...@apache.org> on 2023/04/26 16:35:37 UTC

[GitHub] [superset] betodealmeida commented on a diff in pull request #23829: chore: fix params with marshmallow schema for Datasets

betodealmeida commented on code in PR #23829:
URL: https://github.com/apache/superset/pull/23829#discussion_r1178132286


##########
tests/integration_tests/csv_upload_tests.py:
##########
@@ -556,4 +556,4 @@ def test_import_parquet(mock_event_logger):
 
     with test_db.get_sqla_engine_with_context() as engine:
         data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall()
-        assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)]
+        assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)]

Review Comment:
   ```suggestion
           assert sorted(data) == [('bob', 4), ('john', 1), ('max', 3), ('paul', 2)]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org