You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 17:06:38 UTC
[GitHub] [airflow] uranusjr opened a new pull request #21563: Change TaskInstance.task type to Operator and call unmap() when needed
uranusjr opened a new pull request #21563:
URL: https://github.com/apache/airflow/pull/21563
I traced all the `TaskInstance.task` calls I could find (may not be comprehensive but I did what I could), and analysed whether `task` can be mapped or not on each of their call paths. I added a runtime check when they are guaranteed to be _not_ mapped, and additional `unmap` calls when needed. I also implemented `MappedOperator.resources` since it is needed.
This also depends on the `inlets` and `outlets` properties proposed in #21495 (right now they are type-ignored so CI can pass).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21563: Type TaskInstance.task to Operator and call unmap() when needed
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21563:
URL: https://github.com/apache/airflow/pull/21563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21563: Change TaskInstance.task type to Operator and call unmap() when needed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21563:
URL: https://github.com/apache/airflow/pull/21563#issuecomment-1039349839
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21563: Change TaskInstance.task type to Operator and call unmap() when needed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21563:
URL: https://github.com/apache/airflow/pull/21563#issuecomment-1039349839
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21563: Type TaskInstance.task to Operator and call unmap() when needed
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21563:
URL: https://github.com/apache/airflow/pull/21563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org