[GitHub] [spark] xinglin commented on a diff in pull request #38832: SPARK-41313 Combine fixes for SPARK-3900 and SPARK-21138

[GitBox <gi...@apache.org>]

xinglin commented on code in PR #38832:
URL: https://github.com/apache/spark/pull/38832#discussion_r1035099293


##########
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala:
##########
@@ -240,6 +240,9 @@ private[spark] class ApplicationMaster(
 
       logInfo("ApplicationAttemptId: " + appAttemptId)
 
+      // During shutdown, we may not be able to create an FileSystem object. So, pre-create here.
+      val stagingDirPath = new Path(System.getenv("SPARK_YARN_STAGING_DIR"))
+      val stagingDirFs = stagingDirPath.getFileSystem(yarnConf)

Review Comment:
   The problem is we can not create a new filesystem object (this line ` val stagingDirFs = stagingDirPath.getFileSystem(yarnConf)`), if we are in shutdown and this is the first time we try to create a new filesystem object. We can not register a shutdown hook during a shutdown. That is why we should move the filesystem object creation outside of cleanupStagingDir itself. So, cleanupStagingDir called during shutdown won't try to create a filesystem object.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org