You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/08/13 22:22:51 UTC
Review Request 68306: Fixed an authentication request amplification
issue in the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68306/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-9144
https://issues.apache.org/jira/browse/MESOS-9144
Repository: mesos
Description
-------
Per MESOS-9144, re-enqueuing authentication requests leads to an
amplification effect which can overwhelm the master if requests
continue to arrive rapidly on a heavily loaded master. This patch
avoids the re-enqueing and ensures the master immediately processes
a new authentication request for a client.
Diffs
-----
src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
Diff: https://reviews.apache.org/r/68306/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 68306: Fixed an authentication request
amplification issue in the master.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68306/#review207310
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for noticing this! Those callback amplifications are really hard to find. I just added a couple of nits but feel free to disregard if you disagree with me.
src/master/master.cpp
Line 9601 (original), 9597 (patched)
<https://reviews.apache.org/r/68306/#comment290655>
I feel this level should be _warning_ instead of _info_. In my opinion if we are in this situation, something is going wrong somewhere else and the stability of the system is at stake.
src/master/master.cpp
Lines 9627 (patched)
<https://reviews.apache.org/r/68306/#comment290656>
Same as before, this is probably a warning.
- Alexander Rojas
On Aug. 14, 2018, 12:22 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68306/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 12:22 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-9144
> https://issues.apache.org/jira/browse/MESOS-9144
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-9144, re-enqueuing authentication requests leads to an
> amplification effect which can overwhelm the master if requests
> continue to arrive rapidly on a heavily loaded master. This patch
> avoids the re-enqueing and ensures the master immediately processes
> a new authentication request for a client.
>
>
> Diffs
> -----
>
> src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
>
>
> Diff: https://reviews.apache.org/r/68306/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68306: Fixed an authentication request
amplification issue in the master.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68306/#review207261
-----------------------------------------------------------
Ship it!
- Gastón Kleiman
On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68306/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-9144
> https://issues.apache.org/jira/browse/MESOS-9144
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-9144, re-enqueuing authentication requests leads to an
> amplification effect which can overwhelm the master if requests
> continue to arrive rapidly on a heavily loaded master. This patch
> avoids the re-enqueing and ensures the master immediately processes
> a new authentication request for a client.
>
>
> Diffs
> -----
>
> src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
>
>
> Diff: https://reviews.apache.org/r/68306/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68306: Fixed an authentication request
amplification issue in the master.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68306/#review207244
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 9589-9591 (patched)
<https://reviews.apache.org/r/68306/#comment290557>
Worth adding some explanation as to why we can immediately proceed with the new authentication with the same `pid`.
- Meng Zhu
On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68306/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-9144
> https://issues.apache.org/jira/browse/MESOS-9144
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-9144, re-enqueuing authentication requests leads to an
> amplification effect which can overwhelm the master if requests
> continue to arrive rapidly on a heavily loaded master. This patch
> avoids the re-enqueing and ensures the master immediately processes
> a new authentication request for a client.
>
>
> Diffs
> -----
>
> src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
>
>
> Diff: https://reviews.apache.org/r/68306/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>