You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2024/11/13 05:54:28 UTC
[PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
kezhenxu94 opened a new pull request, #12768:
URL: https://github.com/apache/skywalking/pull/12768
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #12643 .
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12768:
URL: https://github.com/apache/skywalking/pull/12768#discussion_r1839499692
##########
test/e2e-v2/cases/profiling/ebpf/access_log/traffic-gen.yaml:
##########
@@ -33,8 +33,14 @@ spec:
spec:
containers:
- name: trafficgenerator
- image: elswork/wrk
- command: ["wrk", "-t1", "-c1", "-d20m", "http://productpage:9080/productpage"]
Review Comment:
Yes, please update them after this gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #12768:
URL: https://github.com/apache/skywalking/pull/12768#discussion_r1839491126
##########
.github/workflows/skywalking.yaml:
##########
@@ -555,26 +555,31 @@ jobs:
- name: Kafka Log
config: test/e2e-v2/cases/kafka/log/e2e.yaml
- - name: Istio Metrics Service 1.15.0
+ - name: Istio Metrics Service 1.20.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.15.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.16.0
+ ISTIO_VERSION=1.20.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.21.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.16.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.17.0
+ ISTIO_VERSION=1.21.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.22.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.17.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.18.0
+ ISTIO_VERSION=1.22.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.23.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.18.0
- KUBERNETES_VERSION=25
+ ISTIO_VERSION=1.23.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.24.0
+ config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ env: |
+ ISTIO_VERSION=1.24.0
+ KUBERNETES_VERSION=28
- name: Rover with Istio Process 1.15.0
Review Comment:
@mrproliu consider upgrading this istio version to >= 1.20.0 in a separate PR and test whether the eBPF module needs updated, 1.15 is quite old and I donβt think we would like to maintain it anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #12768:
URL: https://github.com/apache/skywalking/pull/12768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #12768:
URL: https://github.com/apache/skywalking/pull/12768#discussion_r1839485331
##########
test/e2e-v2/cases/profiling/ebpf/access_log/traffic-gen.yaml:
##########
@@ -33,8 +33,14 @@ spec:
spec:
containers:
- name: trafficgenerator
- image: elswork/wrk
- command: ["wrk", "-t1", "-c1", "-d20m", "http://productpage:9080/productpage"]
Review Comment:
FYI @mrproliu , letβs avoid using such images that was not updated for 6 years and doesnβt work on Apple's M chip machines. Please consider removing this in satellite repo also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #12768:
URL: https://github.com/apache/skywalking/pull/12768#discussion_r1839491126
##########
.github/workflows/skywalking.yaml:
##########
@@ -555,26 +555,31 @@ jobs:
- name: Kafka Log
config: test/e2e-v2/cases/kafka/log/e2e.yaml
- - name: Istio Metrics Service 1.15.0
+ - name: Istio Metrics Service 1.20.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.15.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.16.0
+ ISTIO_VERSION=1.20.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.21.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.16.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.17.0
+ ISTIO_VERSION=1.21.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.22.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.17.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.18.0
+ ISTIO_VERSION=1.22.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.23.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.18.0
- KUBERNETES_VERSION=25
+ ISTIO_VERSION=1.23.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.24.0
+ config: test/e2e-v2/cases/istio/metrics/e2e.yaml
+ env: |
+ ISTIO_VERSION=1.24.0
+ KUBERNETES_VERSION=28
- name: Rover with Istio Process 1.15.0
Review Comment:
@mrproliu consider upgrading this istio version to >= 1.20.0 and test whether the eBPF module needs updated, 1.15 is quite old and I donβt think we would like to maintain it anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adapt the new metadata standardization in Istio 1.24 [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12768:
URL: https://github.com/apache/skywalking/pull/12768#discussion_r1839485193
##########
.github/workflows/skywalking.yaml:
##########
@@ -555,26 +555,31 @@ jobs:
- name: Kafka Log
config: test/e2e-v2/cases/kafka/log/e2e.yaml
- - name: Istio Metrics Service 1.15.0
+ - name: Istio Metrics Service 1.20.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.15.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.16.0
+ ISTIO_VERSION=1.20.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.21.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.16.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.17.0
+ ISTIO_VERSION=1.21.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.22.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.17.0
- KUBERNETES_VERSION=25
- - name: Istio Metrics Service 1.18.0
+ ISTIO_VERSION=1.22.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.23.0
config: test/e2e-v2/cases/istio/metrics/e2e.yaml
env: |
- ISTIO_VERSION=1.18.0
- KUBERNETES_VERSION=25
+ ISTIO_VERSION=1.23.0
+ KUBERNETES_VERSION=28
+ - name: Istio Metrics Service 1.23.0
Review Comment:
```suggestion
- name: Istio Metrics Service 1.24.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org