You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/28 03:28:31 UTC
[GitHub] [arrow] kou opened a new pull request, #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
kou opened a new pull request, #35362:
URL: https://github.com/apache/arrow/pull/35362
### Rationale for this change
Because Perl in conda doesn't work on Manjaro Linux.
### What changes are included in this PR?
* Use `sed` instead of `perl`.
* Remove `stacktrace_addr2line.pl`. If we still need it, we can re-implement the addr2line filter in other language such as Python or shell later.
### Are these changes tested?
Yes by hand on Manjaro Linux.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1526933301
* Closes: #35361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35362:
URL: https://github.com/apache/arrow/pull/35362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1526933320
:warning: GitHub issue #35361 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1526951195
Yes checking out this PR and applying the patch does work :tada: Thanks for taking this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1527232550
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/c6e8fa6f3fe1494dbc33dff004d6e62b...34530d03a3fd4cce8faad77e4151109a/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e363fa538d644578a82ce3b5952a19f...f472f88835404bc986a057f5afda6a5b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1526934478
@assignUser You can try this for `TEST_DEFAULT=0 TEST_SOURCE=0 TEST_CPP=1 USE_CONDA=1 dev/release/verify-release-candidate.sh 12.0.0 0` with the following patch:
```diff
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 779e71a38..334348a8f 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -599,6 +599,8 @@ test_and_install_cpp() {
ARROW_CMAKE_OPTIONS="${ARROW_CMAKE_OPTIONS:-} -G ${CMAKE_GENERATOR}"
fi
+ cp ${SOURCE_DIR}/../../cpp/build-support/run-test.sh ${ARROW_SOURCE_DIR}/cpp/build-support/
+
cmake \
-DARROW_BOOST_USE_SHARED=ON \
-DARROW_BUILD_EXAMPLES=OFF \
```
I confirmed that the verification command passes with this change on the `manjarolinux/base` Docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1526989395
That's good to know. :-)
Could you share it on the vote thread too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35362: GH-35361: [C++] Remove Perl dependency from cpp/build-support/run-test.sh
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35362:
URL: https://github.com/apache/arrow/pull/35362#issuecomment-1527228498
Benchmark runs are scheduled for baseline = 06d49ee63e26ba685e7da78064e20dd96610e1e1 and contender = 05a61d6fd4fee0c998ae650fa0e67881681e4a5a. 05a61d6fd4fee0c998ae650fa0e67881681e4a5a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a049f5655c94ae8a3f1167c11e30a66...960517c00c7644798a15f29642d620db/)
[Finished :arrow_down:3.43% :arrow_up:1.16%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c6e8fa6f3fe1494dbc33dff004d6e62b...34530d03a3fd4cce8faad77e4151109a/)
[Failed :arrow_down:3.32% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4e363fa538d644578a82ce3b5952a19f...f472f88835404bc986a057f5afda6a5b/)
[Finished :arrow_down:0.36% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0d28544b9b3d4579bb8b06e37ff7b9d2...ca254e72ba024d809b15451a7400c220/)
Buildkite builds:
[Finished] [`05a61d6f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2794)
[Finished] [`05a61d6f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2828)
[Failed] [`05a61d6f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2792)
[Finished] [`05a61d6f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2819)
[Finished] [`06d49ee6` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2793)
[Finished] [`06d49ee6` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2827)
[Finished] [`06d49ee6` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2791)
[Finished] [`06d49ee6` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2818)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org