You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Tim Ellison (JIRA)" <de...@geronimo.apache.org> on 2005/05/10 12:22:08 UTC
[jira] Created: (GERONIMO-644) Serialized form of GBeans objects must each declare SUID
Serialized form of GBeans objects must each declare SUID
--------------------------------------------------------
Key: GERONIMO-644
URL: http://issues.apache.org/jira/browse/GERONIMO-644
Project: Geronimo
Type: Bug
Reporter: Tim Ellison
Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
[1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
[2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-644) Serialized form of GBeans objects must each declare SUID
Posted by "Jeremy Boynes (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Jeremy Boynes reassigned GERONIMO-644:
--------------------------------------
Assign To: Jeremy Boynes
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Reporter: Tim Ellison
> Assignee: Jeremy Boynes
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Matt Hogstrom updated GERONIMO-644:
-----------------------------------
Fix Version: 1.2
(was: 1.1)
We are really going to fix this in 1.2 or close this :)
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.2
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=comments#action_12376510 ]
Dain Sundstrom commented on GERONIMO-644:
-----------------------------------------
If you build the server using the -Dorg.apache.geronimo.kernel.config.Marshaler=org.apache.geronimo.kernel.config.xstream.XStreamConfigurationMarshaler Geronimo will use XStream instead of Java ObjectOutputStream for saving the configurations. This is what we are planning on switching to for 1.2. Unfortunately, xstream does use the Sun unsafe package to create objects. In the mean time, if you have some free time you could supply a patch to this :)
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.2
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Dain Sundstrom updated GERONIMO-644:
------------------------------------
Assign To: (was: Dain Sundstrom)
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Fix For: 1.2
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by Matt Hogstrom <ma...@hogstrom.org>.
Tim,
We have a workaround for some of these issues. I'll let Dain go into further detail. We should use
your testcase to see if this issue still remains or Dain's fix has mitigated it.
Tim Ellison (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/GERONIMO-644?page=comments#action_12376424 ]
>
> Tim Ellison commented on GERONIMO-644:
> --------------------------------------
>
> Thanks Matt, to put it in context, this was one of the problems preventing G coming up on Harmony class libraries (last May).
>
>
>
>>Serialized form of GBeans objects must each declare SUID
>>--------------------------------------------------------
>>
>> Key: GERONIMO-644
>> URL: http://issues.apache.org/jira/browse/GERONIMO-644
>> Project: Geronimo
>> Type: Bug
>
>
>> Components: kernel
>> Reporter: Tim Ellison
>> Assignee: Dain Sundstrom
>> Fix For: 1.2
>
>
>>Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
>>The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
>>I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
>>[1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
>>[2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
>
>
[jira] Commented: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Tim Ellison (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=comments#action_12376424 ]
Tim Ellison commented on GERONIMO-644:
--------------------------------------
Thanks Matt, to put it in context, this was one of the problems preventing G coming up on Harmony class libraries (last May).
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.2
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Dain Sundstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Dain Sundstrom updated GERONIMO-644:
------------------------------------
Component: kernel
Fix Version: 1.1
(was: 1.x)
Assign To: Dain Sundstrom (was: Jeremy Boynes)
With the introduction of XML based configurations using XStream in 1.1 we no longer have a serialization issue. Regardless, we should be declaring serial version id on all classes that implement serialization.
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Assignee: Dain Sundstrom
> Fix For: 1.1
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-644) Serialized form of GBeans objects must each declare SUID
Posted by "Matt Hogstrom (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Matt Hogstrom updated GERONIMO-644:
-----------------------------------
Fix Version: 1.x
(was: 1.0)
We need to address this issue but its not likely to be resolved in the next few weeks. Deferring to 1.x and would like Dain's comments on how xbean may help to reduce this issue.
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Reporter: Tim Ellison
> Assignee: Jeremy Boynes
> Fix For: 1.x
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-644) Serialized form of GBeans objects must each declare SUID
Posted by "Tim Ellison (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=comments#action_65490 ]
Tim Ellison commented on GERONIMO-644:
--------------------------------------
There is a handy Eclipse compile time check for "Serializable class without serialversionUID", which would catch them all at compile time, but for now here's a couple I found with a runtime test bringing up bin\server.jar on 1.0-M3.
----
The class org.codehaus.activemq.message.DefaultWireFormat does not declare an SUID.
To retain compatibility with existing persistent form it should declare:
static final long serialVersionUID =-8707485428936851184L;
----
There is a serializable class hierarchy rooted at org.apache.geronimo.gbean.GAttributeInfo that does not declare a SUID.
Bringing up the bin\server.jar exposed:
org.apache.geronimo.gbean.DynamicGAttributeInfo
which to retain compatibility with existing persistent forms should declare
static final long serialVersionUID =-3766690289494192629L;
----
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Reporter: Tim Ellison
> Assignee: Jeremy Boynes
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-644) Serialized form of GBeans objects
must each declare SUID
Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Matt Hogstrom closed GERONIMO-644.
----------------------------------
Resolution: Later
This problem is a project issue and a development standard. We'll address this through documentation.
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Issue Type: Bug
> Components: kernel
> Reporter: Tim Ellison
> Fix For: 1.2
>
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-644) Serialized form of GBeans objects must each declare SUID
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-644?page=all ]
Aaron Mulder updated GERONIMO-644:
----------------------------------
Fix Version: 1.0
Description:
Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
[1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
[2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
was:
Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
[1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
[2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
Environment:
This is going to be a vast job -- I think it would ultimately be easier to reduce our reliance on serialization. However, if we go forward with serialization for 1.0, we ought to seriously consider this to facilitate upgrades and so on.
If we decide this is too much work but can't replace serialization, perhaps we can eliminate the serialized state in favor of the ManageableAttributeStore, and include the original plan in the config store. Then in an upgrade scenario we'd export all the plans and the ManageableAttributeStore file, upgrade the server components, restore the ManageableAttributeStore file, and redeploy all the plans. This would be hard but potentially less work than tracking down and altering every relevant Serializable object.
> Serialized form of GBeans objects must each declare SUID
> --------------------------------------------------------
>
> Key: GERONIMO-644
> URL: http://issues.apache.org/jira/browse/GERONIMO-644
> Project: Geronimo
> Type: Bug
> Reporter: Tim Ellison
> Assignee: Jeremy Boynes
> Fix For: 1.0
>
> Since Geronimo exchanges config information via serialized form of Java objects, its imperative that the serializable classes declare a serialVersionUID. If they don't then the serialized form is not necessarily compatible across Java implementations (or even Java compilers) [1].
> The case in point is the wire format classes in ActiveMQ (e.g. "org.codehaus.activemq.message.DefaultWireFormat") which are marked serializable and do not declare a static ID. I've tried raising this with ActiveMQ [2] but without success.
> I can provide the required SUID in each case, but it looks like I might need help to get it into the ActiveMQ code.
> [1] http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc6.html#4100
> [2] http://article.gmane.org/gmane.comp.java.activemq.devel/486
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira