You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Randall Hauch (Jira)" <ji...@apache.org> on 2019/10/15 22:57:00 UTC
[jira] [Commented] (KAFKA-8947) Connect framework incorrectly
instantiates TaskStates for REST extensions
[ https://issues.apache.org/jira/browse/KAFKA-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952356#comment-16952356 ]
Randall Hauch commented on KAFKA-8947:
--------------------------------------
[~ChrisEgerton], I've merged this to the `trunk` and `2.3` branch, but I can't easily backport any further because the updated integration tests rely upon KAFKA-8231 / [KIP-454|https://cwiki.apache.org/confluence/display/KAFKA/KIP-454%3A+Expansion+of+the+ConnectClusterState+interface] does not exist in branches earlier than `2.3`.
We can merge this back farther, but I'd probably need a different PR targeting the `2.2` branch.
> Connect framework incorrectly instantiates TaskStates for REST extensions
> -------------------------------------------------------------------------
>
> Key: KAFKA-8947
> URL: https://issues.apache.org/jira/browse/KAFKA-8947
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.1.1, 2.0.2, 2.3.0, 2.1.2, 2.2.1, 2.2.2, 2.4.0, 2.3.1, 2.2.3
> Reporter: Chris Egerton
> Assignee: Chris Egerton
> Priority: Major
> Fix For: 2.4.0, 2.3.1
>
>
> The {{TaskState}} class's [constructor|https://github.com/apache/kafka/blob/666505b72f1baaf5f37fac4f59fa26d93d833f63/connect/api/src/main/java/org/apache/kafka/connect/health/TaskState.java#L37-L40] takes in parameters for the task's ID number, state, worker, and (optionally-null) error stack trace, in that order. However, the Connect framework's {{ConnectClusterStateImpl}} class instantiates TaskState objects with a different ordering of arguments: [ID number, worker, state, trace|https://github.com/apache/kafka/blob/36a5aba4ecf56631372ad12d5c67af8fa3de05f8/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/health/ConnectClusterStateImpl.java#L110].
> It's possible that this (erroneous) behavior has already been identified and worked around by developers of REST extensions, so it's questionable whether a patch PR here is warranted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)