You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "kevin su (JIRA)" <ji...@apache.org> on 2019/01/20 16:42:00 UTC
[jira] [Commented] (HBASE-18837) HTableMultiplexer behavior during
regions split
[ https://issues.apache.org/jira/browse/HBASE-18837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747495#comment-16747495 ]
kevin su commented on HBASE-18837:
----------------------------------
{{ScheduledExecutorService executor won't not retry to put, if we don't catch the Exception.}}
{{It will stuck by exception.}}
{{Hope this patch help, btw, could i have opportunity to be assigned this issue.}}
{{I will try my best to solved it.}}
> HTableMultiplexer behavior during regions split
> -----------------------------------------------
>
> Key: HBASE-18837
> URL: https://issues.apache.org/jira/browse/HBASE-18837
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.1.2
> Reporter: chausson
> Priority: Minor
>
> HTableMultiplexer class mentions following in the javadoc : "If any queue is full, the HTableMultiplexer starts to drop the Put requests for that particular queue."
> This could be improved by replacing following code in HTableMultiplexer.resubmitFailedPut() method :
> {code:title=HTableMultiplexer}
> try {
> succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, retryCount);
> } finally {
> FlushWorker.this.getRetryInQueue().decrementAndGet();
> if (!succ) {
> FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
> }
> }
> {code}
> With :
> {code}
> try {
> succ = FlushWorker.this.getMultiplexer().put(tableName, failedPut, retryCount);
> if (!succ) {
> if (!resubmitFailedPut(ps, oldLoc)) {
> FlushWorker.this.getTotalFailedPutCount().incrementAndGet();
> }
> }
> } finally {
> FlushWorker.this.getRetryInQueue().decrementAndGet();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)