You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/12 04:27:00 UTC

[GitHub] [rocketmq] duhenglucky opened a new pull request #2867: [RIP-19] Server-side rebalance, Pop consumption model

duhenglucky opened a new pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls commented on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-839440287


   
   [![Coverage Status](https://coveralls.io/builds/39602751/badge)](https://coveralls.io/builds/39602751)
   
   Coverage increased (+0.3%) to 52.668% when pulling **7d32c02cf4e1dc160f62faee3bfe7bde149006b8 on pop_consumer** into **f2a5a747fbf248776340f4a99118d421de2a5310 on develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-839440287


   
   [![Coverage Status](https://coveralls.io/builds/40956219/badge)](https://coveralls.io/builds/40956219)
   
   Coverage decreased (-1.2%) to 52.583% when pulling **48fa70bc8c3f55ca70b879f69110923977ef2fbb on pop_consumer** into **df1d93fc8859377b92ba87c6947911281656f355 on 5.0.0-preview**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter commented on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-870335211


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2867](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (48fa70b) into [5.0.0-preview](https://codecov.io/gh/apache/rocketmq/commit/df1d93fc8859377b92ba87c6947911281656f355?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df1d93f) will **decrease** coverage by `1.48%`.
   > The diff coverage is `30.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2867/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##             5.0.0-preview    #2867      +/-   ##
   ===================================================
   - Coverage            47.97%   46.49%   -1.49%     
   - Complexity            4570     4789     +219     
   ===================================================
     Files                  552      591      +39     
     Lines                36628    40253    +3625     
     Branches              4844     5454     +610     
   ===================================================
   + Hits                 17573    18716    +1143     
   - Misses               16832    19071    +2239     
   - Partials              2223     2466     +243     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...balance/AllocateMessageQueueAveragelyByCircle.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWVzc2FnZVF1ZXVlQXZlcmFnZWx5QnlDaXJjbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.84% <0.00%> (-0.15%)` | :arrow_down: |
   | [...impl/consumer/ConsumeMessagePopOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZVBvcE9yZGVybHlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...rocketmq/client/impl/consumer/PopProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qb3BQcm9jZXNzUXVldWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ache/rocketmq/client/impl/consumer/PopRequest.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qb3BSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `42.14% <0.00%> (-8.29%)` | :arrow_down: |
   | [...cketmq/client/impl/consumer/RebalancePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdWxsSW1wbC5qYXZh) | `19.23% <0.00%> (-4.58%)` | :arrow_down: |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `50.00% <0.00%> (-2.41%)` | :arrow_down: |
   | [...in/java/org/apache/rocketmq/common/KeyBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vS2V5QnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/rocketmq/common/PopAckConstants.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vUG9wQWNrQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [129 more](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df1d93f...48fa70b](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky merged pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] duhenglucky merged pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] vongosling commented on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-843731469


   resolve conflict, and we could review after merge it, release it in 4.9.0 after 4.8.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] codecov-commenter commented on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-870335211


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2867](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (48fa70b) into [5.0.0-preview](https://codecov.io/gh/apache/rocketmq/commit/df1d93fc8859377b92ba87c6947911281656f355?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df1d93f) will **decrease** coverage by `1.48%`.
   > The diff coverage is `30.18%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2867/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##             5.0.0-preview    #2867      +/-   ##
   ===================================================
   - Coverage            47.97%   46.49%   -1.49%     
   - Complexity            4570     4789     +219     
   ===================================================
     Files                  552      591      +39     
     Lines                36628    40253    +3625     
     Branches              4844     5454     +610     
   ===================================================
   + Hits                 17573    18716    +1143     
   - Misses               16832    19071    +2239     
   - Partials              2223     2466     +243     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...balance/AllocateMessageQueueAveragelyByCircle.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvcmViYWxhbmNlL0FsbG9jYXRlTWVzc2FnZVF1ZXVlQXZlcmFnZWx5QnlDaXJjbGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `38.84% <0.00%> (-0.15%)` | :arrow_down: |
   | [...impl/consumer/ConsumeMessagePopOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZVBvcE9yZGVybHlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...rocketmq/client/impl/consumer/PopProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qb3BQcm9jZXNzUXVldWUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ache/rocketmq/client/impl/consumer/PopRequest.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qb3BSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../rocketmq/client/impl/consumer/PullAPIWrapper.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsQVBJV3JhcHBlci5qYXZh) | `42.14% <0.00%> (-8.29%)` | :arrow_down: |
   | [...cketmq/client/impl/consumer/RebalancePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdWxsSW1wbC5qYXZh) | `19.23% <0.00%> (-4.58%)` | :arrow_down: |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `50.00% <0.00%> (-2.41%)` | :arrow_down: |
   | [...in/java/org/apache/rocketmq/common/KeyBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vS2V5QnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...va/org/apache/rocketmq/common/PopAckConstants.java](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vUG9wQWNrQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | ... and [129 more](https://codecov.io/gh/apache/rocketmq/pull/2867/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df1d93f...48fa70b](https://codecov.io/gh/apache/rocketmq/pull/2867?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-839440287


   
   [![Coverage Status](https://coveralls.io/builds/39804584/badge)](https://coveralls.io/builds/39804584)
   
   Coverage decreased (-1.7%) to 52.29% when pulling **e84221d6089ccb3fffb5e3a223935d3bf26f811e on pop_consumer** into **8a2554dfe6d97c561ba19ec8051fe25391c7a5af on develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-839440287


   
   [![Coverage Status](https://coveralls.io/builds/40956219/badge)](https://coveralls.io/builds/40956219)
   
   Coverage decreased (-1.2%) to 52.583% when pulling **48fa70bc8c3f55ca70b879f69110923977ef2fbb on pop_consumer** into **df1d93fc8859377b92ba87c6947911281656f355 on 5.0.0-preview**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] coveralls edited a comment on pull request #2867: [RIP-19] Server-side rebalance, lightweight consumer client support

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2867:
URL: https://github.com/apache/rocketmq/pull/2867#issuecomment-839440287


   
   [![Coverage Status](https://coveralls.io/builds/39804998/badge)](https://coveralls.io/builds/39804998)
   
   Coverage decreased (-1.5%) to 52.42% when pulling **d98192b29dd08670375e516b8681f8576589206a on pop_consumer** into **8a2554dfe6d97c561ba19ec8051fe25391c7a5af on develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org