You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by samk1 <gi...@git.apache.org> on 2016/07/04 10:01:36 UTC

[GitHub] couchdb-fauxton pull request #742: database ID gets URI encoded twice on url...

GitHub user samk1 opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/742

    database ID gets URI encoded twice on url()

    Closes COUCHDB-3051

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/samk1/couchdb-fauxton 3051-double-url-encode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #742
    
----
commit d4173de2c733c714c6124f71c1c575d2da5492a7
Author: samk <sa...@gmail.com>
Date:   2016-07-04T07:59:37Z

    remove '-' character from bad characters class

commit 5f2132771b0255a7e5f57bf66d6c680a4031b827
Author: samk <sa...@gmail.com>
Date:   2016-07-04T09:35:03Z

    found a less global way to solve the problem: remove the second call to safeURLName

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request #742: database ID gets URI encoded twice on url...

Posted by samk1 <gi...@git.apache.org>.

Github user samk1 closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/742


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #742: database ID gets URI encoded twice on url()

Posted by samk1 <gi...@git.apache.org>.

Github user samk1 commented on the issue:

    https://github.com/apache/couchdb-fauxton/pull/742
  
    Ok, I think I get it - currently couchdb throws an error if you create a database called a$, but creates the database anyway. In new versions will it not create the database at all?
    
    Similarly with a$-, it creates the database except fauxton is unable to get the status due to the double encode. When the backend is fixed, such a database will not be able to exist.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton issue #742: database ID gets URI encoded twice on url()

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the issue:

    https://github.com/apache/couchdb-fauxton/pull/742
  
    thanks for the PR! 
    
    sadly it does not solve the root issue (try to create a database with the name `a%24` and another with the name "a$"
    
    the root cause of the problem is a backend issue. in new versions, couchdb will reject those database names: https://issues.apache.org/jira/browse/COUCHDB-2748


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---