You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Chaoyu Tang <ct...@gmail.com> on 2016/09/07 12:49:55 UTC

Re: Review Request 51395: HIVE-14626: Support Trash in Truncate Table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51395/
-----------------------------------------------------------

(Updated Sept. 7, 2016, 12:49 p.m.)


Review request for hive.


Changes
-------

Revised the patch based on Sergio's review - only to clean the directory contents when it is protected by encryption zone, for other cases, we still do trash/delete the directory followed by recreation which might have a better performance especially for S3 cases.


Bugs: HIVE-14626
    https://issues.apache.org/jira/browse/HIVE-14626


Repository: hive-git


Description
-------

Truncate table/partition is implemented to clean the contents of table/partiton directory using multi-threaded trashFiles instead of deleting/recreating the directory, so the encryption level is preserved if any. In addition, it supports the HDFS Trash.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a59b781 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 5f53aef 
  ql/src/test/queries/clientpositive/encryption_drop_partition.q 57dfabd 
  ql/src/test/queries/clientpositive/encryption_drop_table.q 2ae3c69 
  ql/src/test/results/clientpositive/encrypted/encryption_drop_partition.q.out 2643006 
  ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out c5007ee 

Diff: https://reviews.apache.org/r/51395/diff/


Testing
-------

Manual tests
New ptests
precommit tests


Thanks,

Chaoyu Tang