You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "GuoPhilipse (via GitHub)" <gi...@apache.org> on 2023/03/30 14:54:16 UTC

[GitHub] [linkis] GuoPhilipse commented on a diff in pull request #4428: Merge 1.3.2 to1.4.0

GuoPhilipse commented on code in PR #4428:
URL: https://github.com/apache/linkis/pull/4428#discussion_r1153388971


##########
.github/workflows/build-backend.yml:
##########
@@ -20,24 +20,72 @@ name: Build Backend
 on: [push, pull_request]
 
 env:
-  MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
+  MAVEN_OPTS: -Dmaven.resolver.transport=wagon -Dmaven.wagon.httpconnectionManager.ttlSeconds=30
 
 jobs:
   build-backend:
     runs-on: ubuntu-latest
-
+    strategy:
+      matrix:
+        spark: [2.4, 3.2]
+        hadoop: [3.3]
+        include:
+          - spark: 2.4
+            hadoop: 2.7
     steps:
     - name: Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
     - name: Set up JDK 8
-      uses: actions/setup-java@v2
+      uses: actions/setup-java@v3
       with:
         distribution: 'temurin'
         java-version: 8
-    - name: Build backend by maven
+        cache: maven
+    - if: ${{matrix.spark == '2.4' && matrix.hadoop == '3.3'}}
+      name: build spark ${{matrix.spark}} and hadoop ${{matrix.hadoop}}
+      run:
+        ./mvnw clean package -Pspark-${{matrix.spark}}-hadoop-${{matrix.hadoop}} -Phadoop-${{matrix.hadoop}} -Dmaven.test.skip=true

Review Comment:
   for hadoop/spark version will upgrade to 3.x by default in linkis-1.4.0, `spark-2.4-hadoop-3.3` and `hadoop-3.3` profile may not need. and we may need to have `spark-2.4` and `hadoop-2.7` profile 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org