You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/31 17:20:57 UTC

[GitHub] [couchdb] rnewson commented on a change in pull request #3588: Aegis improvements

rnewson commented on a change in pull request #3588:
URL: https://github.com/apache/couchdb/pull/3588#discussion_r642609852



##########
File path: src/aegis/src/aegis_server.erl
##########
@@ -286,8 +278,10 @@ is_key_fresh(UUID) ->
     Now = fabric2_util:now(sec),
 
     case ets:lookup(?KEY_CHECK, UUID) of
-        [{UUID, ExpiresAt}] when ExpiresAt >= Now -> true;
-        _ -> false
+        [{UUID, ExpiresAt}] when ExpiresAt - ?KEY_EARLY_EXPIRE_SEC > Now ->

Review comment:
       same question here. In epep we had a 'fresh', 'stale' and 'expired' category for this kind of thing (where a stale entry was usable until expired, and we forced a refresh when we first notice its stale). Did I really forget to do the same thing here? :(




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org