You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2026/06/10 02:24:48 UTC
[PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
lidavidm opened a new pull request, #4377:
URL: https://github.com/apache/arrow-adbc/pull/4377
Closes #4374.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #4377:
URL: https://github.com/apache/arrow-adbc/pull/4377#discussion_r3395245389
##########
rust/driver/datafusion/Cargo.toml:
##########
@@ -33,16 +33,16 @@ categories.workspace = true
[dependencies]
adbc_core.workspace = true
adbc_ffi = { workspace = true, optional = true }
-arrow-array = { version = ">=58.1, <59", default-features = false }
-arrow-buffer = { version = ">=58.1, <59", default-features = false }
-arrow-schema = { version = ">=58.1, <59", default-features = false }
-datafusion = { version = "53.1.0", default-features = false }
-datafusion-substrait = { version = "53.1.0", default-features = false }
+arrow-array = { version = ">=58.1, <60", default-features = false }
+arrow-buffer = { version = ">=58.1, <60", default-features = false }
+arrow-schema = { version = ">=58.1, <60", default-features = false }
Review Comment:
My attempt is #4384.
I think the CI wasn't very good...
In any case, I think it makes sense to remove `adbc_datafusion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on code in PR #4377:
URL: https://github.com/apache/arrow-adbc/pull/4377#discussion_r3385327497
##########
rust/driver/datafusion/Cargo.toml:
##########
@@ -33,16 +33,16 @@ categories.workspace = true
[dependencies]
adbc_core.workspace = true
adbc_ffi = { workspace = true, optional = true }
-arrow-array = { version = ">=58.1, <59", default-features = false }
-arrow-buffer = { version = ">=58.1, <59", default-features = false }
-arrow-schema = { version = ">=58.1, <59", default-features = false }
-datafusion = { version = "53.1.0", default-features = false }
-datafusion-substrait = { version = "53.1.0", default-features = false }
+arrow-array = { version = ">=58.1, <60", default-features = false }
+arrow-buffer = { version = ">=58.1, <60", default-features = false }
+arrow-schema = { version = ">=58.1, <60", default-features = false }
Review Comment:
I believe these lines cannot be changed because Datafusion 54 is not compatible with arrow 59.
https://github.com/apache/datafusion/blob/45d943dfb8699dc9cb9ef2320e955b73e3e6c03b/Cargo.toml#L91-L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed pull request #4377: build(rust): enable compatibility with arrow 58 and 59
URL: https://github.com/apache/arrow-adbc/pull/4377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #4377:
URL: https://github.com/apache/arrow-adbc/pull/4377#discussion_r3392994866
##########
rust/driver/datafusion/Cargo.toml:
##########
@@ -33,16 +33,16 @@ categories.workspace = true
[dependencies]
adbc_core.workspace = true
adbc_ffi = { workspace = true, optional = true }
-arrow-array = { version = ">=58.1, <59", default-features = false }
-arrow-buffer = { version = ">=58.1, <59", default-features = false }
-arrow-schema = { version = ">=58.1, <59", default-features = false }
-datafusion = { version = "53.1.0", default-features = false }
-datafusion-substrait = { version = "53.1.0", default-features = false }
+arrow-array = { version = ">=58.1, <60", default-features = false }
+arrow-buffer = { version = ">=58.1, <60", default-features = false }
+arrow-schema = { version = ">=58.1, <60", default-features = false }
Review Comment:
Hmm, even if I revert it it still won't build...I think we may want to consider removing the datafusion crate now that there's a thirdparty datafusion driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] build(rust): enable compatibility with arrow 58 and 59 [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #4377:
URL: https://github.com/apache/arrow-adbc/pull/4377#issuecomment-4665887506
CC @eitsupi. If you'd rather fix this up yourself just let me know (I'm not quite sure I got this right)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org