[GitHub] [spark] cloud-fan commented on a diff in pull request #41062: [SPARK-43313][SQL][FOLLOWUP] Improvement for DSv2 API SupportsCustomSchemaWrite

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41062:
URL: https://github.com/apache/spark/pull/41062#discussion_r1188150731


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/SupportsCustomSchemaWrite.java:
##########
@@ -27,12 +28,12 @@
  * @since 3.4.1
  */
 @Evolving
-public interface SupportsCustomSchemaWrite {
+public interface SupportsCustomSchemaWrite extends Table {
     /**
      * Represents a table with a custom schema to use for resolving DEFAULT column references when
      * inserting into the table. For example, this can be useful for excluding hidden pseudocolumns.
      *
      * @return the new schema to use for this process.
      */
-    StructType customSchemaForInserts();
+    Column[] customColumnsForInserts();

Review Comment:
   This is a breaking change and we need to avoid it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org