You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/07/06 01:22:28 UTC
[kudu-CR] [tests] fix on client samples
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7359
Change subject: [tests] fix on client_samples
......................................................................
[tests] fix on client_samples
This patch fixes the following issues with the client_samples-test:
* Use replication factor of 1 since only one tablet server is running
* Added consistency check to make sure the C++ client sample
application talks to the expected master and tablet servers
* Fixed setting of shell flags if running the script via specifying
the shell interpreter explicitly, like
/bin/bash <path_to_the_client_samples-tesh.sh_file>
Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
---
M src/kudu/client/client_samples-test.sh
M src/kudu/client/samples/sample.cc
2 files changed, 64 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/7359/1
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] fix on client samples
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [tests] fix on client_samples
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7359/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:
Line 110: .num_replicas(1)
why is this necessary? the master has the --default-num-replicas=1 flag set, so it should fall back to server side default
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [tests] improvements on client samples test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7359
to look at the new patch set (#3).
Change subject: [tests] improvements on client_samples test
......................................................................
[tests] improvements on client_samples test
This patch adds the following improvements for the client_samples-test:
* Added consistency check to make sure the client sample application
talks to the dedicated master and tablet servers. In the prior
version of the script, if running at the machine where Kudu master
and tablet server are running at default ports bound to all network
interfaces (i.e. 0.0.0.0-wildcard bound), the test inadvertently
used that Kudu cluster, not the dedicated one.
* Increased the timeout for the master and the tablet server to start
listening on their RPC ports up to 30 seconds. It was observed that
on busy test VMs it takes a long time for the master and the tablet
server to bootstrap and start serving client requests.
* Updated the setting of the shell options to make them work even if
running the script via explicit interpreter, like
/bin/bash client_samples-tesh.sh
Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
---
M src/kudu/client/client_samples-test.sh
1 file changed, 69 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/7359/3
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [tests] improvements on client samples test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [tests] improvements on client_samples test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [tests] improvements on client samples test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [tests] improvements on client_samples test
......................................................................
[tests] improvements on client_samples test
This patch adds the following improvements for the client_samples-test:
* Added consistency check to make sure the client sample application
talks to the dedicated master and tablet servers. In the prior
version of the script, if running at the machine where Kudu master
and tablet server are running at default ports bound to all network
interfaces (i.e. 0.0.0.0-wildcard bound), the test inadvertently
used that Kudu cluster, not the dedicated one.
* Increased the timeout for the master and the tablet server to start
listening on their RPC ports up to 30 seconds. It was observed that
on busy test VMs it takes a long time for the master and the tablet
server to bootstrap and start serving client requests.
* Updated the setting of the shell options to make them work even if
running the script via explicit interpreter, like
/bin/bash client_samples-tesh.sh
Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Reviewed-on: http://gerrit.cloudera.org:8080/7359
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client_samples-test.sh
1 file changed, 69 insertions(+), 14 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [tests] fix on client samples
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [tests] fix on client_samples
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7359/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:
Line 110: .num_replicas(1)
> woops, that's some remnants from my earlier experements. Good catch -- I'l
Yep, that's exactly the thing which would allow the test to run with some other master and tserver running at default ports and listening on all available interfaces which the previous revision of the script would not catch.
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [tests] fix on client samples
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [tests] fix on client_samples
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7359/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:
Line 110: .num_replicas(1)
> why is this necessary? the master has the --default-num-replicas=1 flag set
woops, that's some remnants from my earlier experements. Good catch -- I'll remove this.
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [tests] fix on client samples
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [tests] fix on client_samples
......................................................................
[tests] fix on client_samples
This patch fixes the following issues with the client_samples-test:
* Added consistency check to make sure the C++ client sample
application talks to the expected master and tablet servers
* Fixed setting of shell flags if running the script via specifying
the shell interpreter explicitly, like
/bin/bash <path_to_the_client_samples-tesh.sh_file>
Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
---
M src/kudu/client/client_samples-test.sh
1 file changed, 63 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/7359/2
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [tests] improvements on client samples test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [tests] improvements on client_samples test
......................................................................
Patch Set 3: Verified+1
unrelated flake in org.apache.kudu.client.ITClient.test
--
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No