You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/11/05 17:41:44 UTC

[jira] Created: (QPID-1436) rubygen generates TypeCode.h that is missing IntegerTypes.h

rubygen generates TypeCode.h that is missing IntegerTypes.h
-----------------------------------------------------------

                 Key: QPID-1436
                 URL: https://issues.apache.org/jira/browse/QPID-1436
             Project: Qpid
          Issue Type: Bug
          Components: Code Generator
    Affects Versions: M4
         Environment: Windows, Visual Studio
            Reporter: Steve Huston
            Assignee: Steve Huston


A recent change to the rubygen code generator for C++ generates a gen/qpid/framing/TypeCode.h with methods that take a uint8_t, but that type requires qpid/sys/IntegerTypes.h to compile on Windows.
This change fixes it:

Index: rubygen/framing.0-10/constants.rb
===================================================================
--- rubygen/framing.0-10/constants.rb   (revision 711592)
+++ rubygen/framing.0-10/constants.rb   (working copy)
@@ -52,6 +52,7 @@
     path="#{@dir}/TypeCode"
     h_file(path) {
       include("<iosfwd>")
+      include("\"qpid/sys/IntegerTypes.h\"")
       namespace(@namespace) {
         scope("enum TypeCode {", "};") {
           genl @amqp.types.map { |t| "#{typecode_enum t} = #{t.code}" if t.code}.compact.join(",\n")


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-1436) rubygen generates TypeCode.h that is missing IntegerTypes.h

Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston resolved QPID-1436.
--------------------------------

       Resolution: Fixed
    Fix Version/s: M4

Committed in svn revision 711609

> rubygen generates TypeCode.h that is missing IntegerTypes.h
> -----------------------------------------------------------
>
>                 Key: QPID-1436
>                 URL: https://issues.apache.org/jira/browse/QPID-1436
>             Project: Qpid
>          Issue Type: Bug
>          Components: Code Generator
>    Affects Versions: M4
>         Environment: Windows, Visual Studio
>            Reporter: Steve Huston
>            Assignee: Steve Huston
>             Fix For: M4
>
>
> A recent change to the rubygen code generator for C++ generates a gen/qpid/framing/TypeCode.h with methods that take a uint8_t, but that type requires qpid/sys/IntegerTypes.h to compile on Windows.
> This change fixes it:
> Index: rubygen/framing.0-10/constants.rb
> ===================================================================
> --- rubygen/framing.0-10/constants.rb   (revision 711592)
> +++ rubygen/framing.0-10/constants.rb   (working copy)
> @@ -52,6 +52,7 @@
>      path="#{@dir}/TypeCode"
>      h_file(path) {
>        include("<iosfwd>")
> +      include("\"qpid/sys/IntegerTypes.h\"")
>        namespace(@namespace) {
>          scope("enum TypeCode {", "};") {
>            genl @amqp.types.map { |t| "#{typecode_enum t} = #{t.code}" if t.code}.compact.join(",\n")

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.