You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/22 03:26:55 UTC

[GitHub] dongjoon-hyun commented on a change in pull request #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.

dongjoon-hyun commented on a change in pull request #23369: [SPARK-26429][SS]add jdbc sink for Structured Streaming.
URL: https://github.com/apache/spark/pull/23369#discussion_r243724491
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcSourceProvider.scala
 ##########
 @@ -87,4 +95,15 @@ class JdbcRelationProvider extends CreatableRelationProvider
 
     createRelation(sqlContext, parameters)
   }
+
+  override def createStreamingWriteSupport(
+    queryId: String,
 
 Review comment:
   Thank you for your contribution, @yanlin-Lynn .
   We need two more spaces for the params. Please refer the other functions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org