You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/09/01 19:32:55 UTC
Review Request 25236: Patch for KAFKA-1619
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1619
https://issues.apache.org/jira/browse/KAFKA-1619
Repository: kafka
Description
-------
remove project perf from build script
Diffs
-----
build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
Diff: https://reviews.apache.org/r/25236/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Stevo Slavic <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/#review53274
-----------------------------------------------------------
Ship it!
Ship It!
- Stevo Slavic
On Sept. 1, 2014, 5:55 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25236/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 5:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1619
> https://issues.apache.org/jira/browse/KAFKA-1619
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix readme
>
>
> fix typo in readme
>
>
> Diffs
> -----
>
> README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
> build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
> settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
>
> Diff: https://reviews.apache.org/r/25236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Jun Rao <ju...@gmail.com>.
> On Sept. 1, 2014, 7:56 p.m., Guozhang Wang wrote:
> > Shall we remove the whole perf directory as well?
Perf is not part of the git repo. It's probably created by the gradle script, which is fixed now.
- Jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/#review52001
-----------------------------------------------------------
On Sept. 1, 2014, 5:55 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25236/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 5:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1619
> https://issues.apache.org/jira/browse/KAFKA-1619
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix readme
>
>
> fix typo in readme
>
>
> Diffs
> -----
>
> README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
> build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
> settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
>
> Diff: https://reviews.apache.org/r/25236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/#review52001
-----------------------------------------------------------
Ship it!
Shall we remove the whole perf directory as well?
- Guozhang Wang
On Sept. 1, 2014, 5:55 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25236/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 5:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1619
> https://issues.apache.org/jira/browse/KAFKA-1619
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix readme
>
>
> fix typo in readme
>
>
> Diffs
> -----
>
> README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
> build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
> settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
>
> Diff: https://reviews.apache.org/r/25236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/#review52093
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Sept. 1, 2014, 5:55 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25236/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2014, 5:55 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1619
> https://issues.apache.org/jira/browse/KAFKA-1619
>
>
> Repository: kafka
>
>
> Description
> -------
>
> fix readme
>
>
> fix typo in readme
>
>
> Diffs
> -----
>
> README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
> build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
> settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
>
> Diff: https://reviews.apache.org/r/25236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/
-----------------------------------------------------------
(Updated Sept. 1, 2014, 5:55 p.m.)
Review request for kafka.
Bugs: KAFKA-1619
https://issues.apache.org/jira/browse/KAFKA-1619
Repository: kafka
Description (updated)
-------
fix readme
fix typo in readme
Diffs (updated)
-----
README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
Diff: https://reviews.apache.org/r/25236/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 25236: Patch for KAFKA-1619
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25236/
-----------------------------------------------------------
(Updated Sept. 1, 2014, 5:40 p.m.)
Review request for kafka.
Bugs: KAFKA-1619
https://issues.apache.org/jira/browse/KAFKA-1619
Repository: kafka
Description (updated)
-------
fix readme
Diffs (updated)
-----
README.md 8cd5cfd1e04dbef3c0878ff477eebea9ac749233
build.gradle 6d6f1a4349d71bd1b56b7cc5c450046a75a83d6e
settings.gradle 6041784d6f84c66bb1e9df2bc112e1b06c0bb000
Diff: https://reviews.apache.org/r/25236/diff/
Testing
-------
Thanks,
Jun Rao