[GitHub] [pinot] JanecekPetr commented on a change in pull request #8013: reduce allocations and speed up StringUtil.sanitizeString

[GitBox <gi...@apache.org>]

JanecekPetr commented on a change in pull request #8013:
URL: https://github.com/apache/pinot/pull/8013#discussion_r783891791



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/StringUtil.java
##########
@@ -26,7 +26,7 @@
   private StringUtil() {
   }
 
-  private static final char NULL_CHARACTER = '\0';
+  private static final String NULL_CHARACTER = "\0";

Review comment:
       If this was my code, which it isn't - I'm not a reviewer, I'm a random lurker -, I'd like to see this comment in the code, not here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org