You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2025/06/20 22:18:58 UTC

(superset) branch master updated: fix: sqlglot linter (#33849)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new f7921399b9 fix: sqlglot linter (#33849)
f7921399b9 is described below

commit f7921399b962e99d33c811b4fe9e5bd8191cd80b
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Fri Jun 20 15:18:52 2025 -0700

    fix: sqlglot linter (#33849)
---
 superset/extensions/pylint.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/superset/extensions/pylint.py b/superset/extensions/pylint.py
index deb0c86572..fc177884da 100644
--- a/superset/extensions/pylint.py
+++ b/superset/extensions/pylint.py
@@ -87,9 +87,12 @@ class SQLParsingLibraryImportChecker(BaseChecker):
     def _is_disallowed(self, file_path: Path, root_mod: str) -> bool:
         # True if sqlglot is imported outside superset/sql,
         # or if any forbidden library is imported anywhere
-        in_superset_sql = file_path.match("**/superset/sql/**/*.py") or file_path.match(
-            "**/superset/sql/*.py"
-        )
+        allowed = {
+            "**/supersql/sql/**/*.py",
+            "**/supersql/sql/*.py",
+            "**/superset/config.py",
+        }
+        in_superset_sql = any(file_path.match(pattern) for pattern in allowed)
         return (root_mod == "sqlglot" and not in_superset_sql) or root_mod in {
             "sqlparse",
             "sqloxide",