[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #515: MINIFICPP-646 - Re-evaluate passing attributes. Potentially deprecate…
URL: https://github.com/apache/nifi-minifi-cpp/pull/515#discussion_r266452946
 
 

 ##########
 File path: nanofi/include/core/cstructs.h
 ##########
 @@ -89,8 +89,7 @@ typedef struct processor_context processor_context;
 
 typedef struct {
   const char *key;
-  void *value;
-  size_t value_size;
+  const char *value;
 
 Review comment:
   I would probably leave the size because a) you don't know if the value is null terminated ( it may not be ) -- and b) as we move away from C++ we will likely manage the memory and update_attribute at that point could/may be a realloc. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services