[GitHub] [beam] dpcollins-google commented on a change in pull request #16308: [BEAM-13430] Remove propdeps and replace with compileOnly

[GitBox <gi...@apache.org>]

dpcollins-google commented on a change in pull request #16308:
URL: https://github.com/apache/beam/pull/16308#discussion_r773331564



##########
File path: sdks/java/extensions/sql/datacatalog/build.gradle
##########
@@ -36,11 +36,11 @@ dependencies {
   implementation library.java.vendored_guava_26_0_jre
   implementation project(path: ":sdks:java:core", configuration: "shadow")
   implementation "org.threeten:threetenbp:1.4.5"
-  provided project(":sdks:java:extensions:sql")
+  compileOnly project(":sdks:java:extensions:sql")
 
   // Dependencies for the example
-  provided project(":sdks:java:io:google-cloud-platform")
-  provided library.java.slf4j_api
+  compileOnly project(":sdks:java:io:google-cloud-platform")
+  compileOnly library.java.slf4j_api

Review comment:
       I think we should purge most provided/compileOnly targets, with the possible exception of the kafka and hadoop clients which are explicitly there for external users to override. However, I'm just trying to keep it as similar as possible to the current build right now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org