You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/08 02:03:01 UTC

[GitHub] [hudi] chaplinthink commented on a change in pull request #3041: [HUDI-1982] Remove unnecessary synchronization

chaplinthink commented on a change in pull request #3041:
URL: https://github.com/apache/hudi/pull/3041#discussion_r647056354



##########
File path: hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java
##########
@@ -132,15 +132,13 @@ private boolean syncIfLocalViewBehind(Context ctx) {
       String lastKnownInstantFromClient =
           ctx.queryParam(RemoteHoodieTableFileSystemView.LAST_INSTANT_TS, HoodieTimeline.INVALID_INSTANT_TS);
       SyncableFileSystemView view = viewManager.getFileSystemView(basePath);
-      synchronized (view) {

Review comment:
       I mean the implementation of view.sync(); already has WriteLock to handle multiple requests from clients concurrently
   
   ```
    try {
         writeLock.lock();
         runSync(oldTimeline, newTimeline);
       } finally {
         writeLock.unlock();
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org