You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/01 23:12:58 UTC
[jira] [Commented] (CURATOR-349) Expose extra metrics in
TracerDriver
[ https://issues.apache.org/jira/browse/CURATOR-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626992#comment-15626992 ]
ASF GitHub Bot commented on CURATOR-349:
----------------------------------------
GitHub user lvfangmin opened a pull request:
https://github.com/apache/curator/pull/172
[CURATOR-349] Use zero as the default session id to keep consistent with ZooKeeper
The default session id inside ZooKeeper is 0, we should keep consistent with it in tracker.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/curator return_zero_if_session_not_exist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit e9bfb4353ae75dd5aa369ae4aa76b9d8cadb7e50
Author: Fangmin Lyu <al...@fb.com>
Date: 2016-11-01T23:05:39Z
keep consistent with the default session id defined in ZooKeeper
----
> Expose extra metrics in TracerDriver
> ------------------------------------
>
> Key: CURATOR-349
> URL: https://issues.apache.org/jira/browse/CURATOR-349
> Project: Apache Curator
> Issue Type: Improvement
> Components: Framework
> Reporter: Fangmin Lv
> Assignee: Jordan Zimmerman
> Fix For: 3.2.1, 2.11.1
>
>
> Currently, the TracerDriver exposed the latency of ZK operations, in multi-tenant environment, extra metrics are required to help tracing and monitoring:
> * the bytes being sent and received, so we can monitor the client usage scenarios.
> * which ensemble participant the client is talking to, used to find out the problematic Zk server when the issue happened.
> * the z-node path, to easily find out which z-node caused the problem, like high load, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)