You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2026/02/18 19:43:36 UTC
[PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
thisisnic opened a new pull request, #49333:
URL: https://github.com/apache/arrow/pull/49333
### Rationale for this change
testthat 3.3.0 added `expect_r6_class()` which we had implemented ourselves. This removes our custom implementation in favor of the upstream version.
### What changes are included in this PR?
- Bump testthat requirement from >= 3.1.0 to >= 3.3.0
- Remove custom `expect_r6_class()` from helper-expectation.R
### Are these changes tested?
Existing tests use `expect_r6_class()` extensively and will exercise the testthat version.
### Are there any user-facing changes?
No.
---
This PR was generated by Claude. All outputs were reviewed and confirmed before pushing.
* GitHub Issue: #48145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #49333:
URL: https://github.com/apache/arrow/pull/49333#issuecomment-3938853848
@github-actions crossbow submit test-r-arrow-backwards-compatibility test-r-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49333:
URL: https://github.com/apache/arrow/pull/49333#issuecomment-3938856792
Revision: a724e739221c989def4c01e1877e0e0d017b3849
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a839e0224e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a839e0224e)
|Task|Status|
|----|------|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/22258314615/job/64392514800)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/22258314612/job/64392514829)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #49333:
URL: https://github.com/apache/arrow/pull/49333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49333:
URL: https://github.com/apache/arrow/pull/49333#issuecomment-3922820043
:warning: GitHub issue #48145 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48145: [R] Update to testthat 3.3.0 and use its expect_r6_class() [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49333:
URL: https://github.com/apache/arrow/pull/49333#issuecomment-3947394289
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 61741aa3309448f74e2911ff390ccf64265bff5e.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/64594071915) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org