You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2001/06/07 12:32:20 UTC
Re: cvs commit: httpd-2.0/support Makefile.in
On Thu, Jun 07, 2001 at 10:03:31AM -0000, orlikowski@apache.org wrote:
> orlikowski 01/06/07 03:03:30
>
> Modified: . CHANGES configure.in
> modules/mappers mod_so.c
> server .cvsignore Makefile.in
> . configure.in
> include/arch/unix networkio.h
> network_io/unix poll.c
> support Makefile.in
You accidentally slipped in some kqueue work with this.
[ when will people stop doing a commit from the top of their tree without
specifying the files? it seems every couple months, somebody goes to the
top of their tree and does "cvs commit" and we end up with random stuff
going in... sigh :-) ]
Also, shouldn't the old httpd.exp be removed?
>...
> --- Makefile.in 2001/06/06 19:37:06 1.46
> +++ Makefile.in 2001/06/07 10:03:13 1.47
> @@ -1,7 +1,7 @@
>
> TARGET_EXPORTS = apache.exports
> CLEAN_TARGETS = gen_test_char test_char.h gen_uri_delims uri_delims.h \
> - $(TARGET_EXPORTS) ApacheCoreOS2.def
> + $(TARGET_EXPORTS) ApacheCoreOS2.def httpd.exp
> EXTRACLEAN_TARGETS = exports.c
>
> SUBDIRS = mpm
> @@ -16,7 +16,7 @@
> util_filter.c exports.c buildmark.c scoreboard.c \
> error_bucket.c protocol.c core.c request.c
>
> -TARGETS = delete-exports $(LTLIBRARY_NAME) $(CORE_IMPLIB_FILE)
> +TARGETS = delete-exports $(LTLIBRARY_NAME) $(CORE_IMPLIB_FILE) httpd.exp
It would be nice to generate this only for the AIX platform. i.e. create a
configure rule to substitute this in when needed. Something like:
TARGETS = ... @EXP_TARGET@
configure.in would leave it blank, or insert httpd.exp
>...
> --- Makefile.in 2001/05/18 00:48:57 1.15
> +++ Makefile.in 2001/06/07 10:03:29 1.16
> @@ -12,7 +12,7 @@
>
> install:
> @test -d $(bindir) || $(MKINSTALLDIRS) $(bindir)
> - @cp -p httpd.exp $(bindir)
> + @cp -p $(top_srcdir)/server/httpd.exp $(bindir)
> @cp -p apachectl $(bindir)
> chmod 755 $(bindir)/apachectl
> @if test -f $(builddir)/apxs; then \
Hmm. Now that httpd.exp is no longer in support, shouldn't its installation
be handled by a different makefile?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: httpd-2.0/support Makefile.in
Posted by "Victor J. Orlikowski" <v....@gte.net>.
My apologies. Been up most of the night.
Thanks for the catch, Greg. Caught it myself seconds before you did.
That'll teach me to commit on little sleep :)
And no, I'm leaving the old httpd.exp in there temporarily, until any
missing symbols are verified as such (unless you believe that I should
simply leave it to the cvs history, Greg).
Victor
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
orlikowski@apache.org
vjo@us.ibm.com
Re: cvs commit: httpd-2.0/support Makefile.in
Posted by Ben Laurie <be...@algroup.co.uk>.
Greg Stein wrote:
>
> On Thu, Jun 07, 2001 at 10:03:31AM -0000, orlikowski@apache.org wrote:
> > orlikowski 01/06/07 03:03:30
> >
> > Modified: . CHANGES configure.in
> > modules/mappers mod_so.c
> > server .cvsignore Makefile.in
> > . configure.in
> > include/arch/unix networkio.h
> > network_io/unix poll.c
> > support Makefile.in
>
> You accidentally slipped in some kqueue work with this.
>
> [ when will people stop doing a commit from the top of their tree without
> specifying the files? it seems every couple months, somebody goes to the
> top of their tree and does "cvs commit" and we end up with random stuff
> going in... sigh :-) ]
I always commit from the top - but I also (almost) always precede it
with a cvs diff -u so I check what I'm about to commit!
Selective commiting is dangerous - how do you know what you are
committing works?
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff