[GitHub] [incubator-mxnet] yuxihu commented on a change in pull request #14480: Tidy up storage allocation and deallocation

[GitBox <gi...@apache.org>]

yuxihu commented on a change in pull request #14480: Tidy up storage allocation and deallocation
URL: https://github.com/apache/incubator-mxnet/pull/14480#discussion_r269300641
 
 

 ##########
 File path: src/storage/cpu_device_storage.h
 ##########
 @@ -63,21 +62,26 @@ class CPUDeviceStorage {
 #endif
 };  // class CPUDeviceStorage
 
-inline void* CPUDeviceStorage::Alloc(Storage::Handle* handle) {
+inline void CPUDeviceStorage::Alloc(Storage::Handle* handle) {
+  void* ptr = nullptr;
 
 Review comment:
   The old function returns a ptr. I did not change this part when I changed the function return type. I think we can remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services